Review 9.5 Merged

65613[BUGFIX] Don't call ResourceFactory::getStorageObject twice

Helmut Hummel CR +2 V +2 Easy +21 −7 updated 09/07/20, 09:11

Commit message

In http://review.typo3.org/11011 a plain DB call
that fetched the storage record was replaced with
usage of StorageRepository::findByUid, which in
turn calls ResourceFactory::getStorageObject again.

This leads to all events also called twice.

To avoid this a new internal method is introduced
on StorageRepository, which only fetches the storage
row again.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Helmut Hummel uploaded patch set 1 09/07/20, 07:55

  2. Helmut Hummel uploaded patch set 2 09/07/20, 07:56

  3. TYPO3com voted on patch set 1 V +1 09/07/20, 08:09 Completed build in 13m 02s on Mon, 7 Sep, 08:09 AM Test Summary: 75145 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-776

  4. TYPO3com voted on patch set 2 V +1 09/07/20, 08:17 Completed build in 21m 22s on Mon, 7 Sep, 08:17 AM Test Summary: 75145 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-777

  5. Helmut Hummel voted on patch set 2 V +2 CR +2 09/07/20, 09:11

  6. Helmut Hummel merged patch set 3 09/07/20, 09:11