Review main Merged

65614[BUGFIX] Evaluate drag elements language in page modules Drag&Drop

Oli Bartsch CR +2 V +2 Easy +11 −4 updated 09/09/20, 19:25

Commit message

The underling JavaScript of the Drag&Drop functionality in the page
module passes the columns language, the element is dropped in, to the
DataHandler. This results in L=-1 elements gets changed to L=0 when
moved around in their column.

This is now fixed by using the language uid of the dragged element
instead of the column if elements language is -1.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 45

  1. Oli Bartsch uploaded patch set 1 09/07/20, 08:12

  2. TYPO3com voted on patch set 1 V +1 09/07/20, 08:27 Completed build in 12m 54s on Mon, 7 Sep, 08:27 AM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5311

  3. Benni Mack voted on patch set 1 V +1 CR +1 09/09/20, 11:44

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 09/09/20, 19:25

  5. Christian Kuhn merged patch set 2 09/09/20, 19:25