Review 9.5 Merged

65616[TASK] Add possibility to create random values in JavaScript

Oliver Hader CR +2 V +2 Easy +16 −1 updated 09/07/20, 16:41

Commit message

New `SecurityUtility. getRandomHexValue(20)` returns 20 hexadecimal
characters provided by the Web Crypto API.

see https://developer.mozilla.org/en-US/docs/Web/API/Web_Crypto_API

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 69

  1. Oliver Hader uploaded patch set 1 09/07/20, 11:26

  2. TYPO3com voted on patch set 1 V -1 09/07/20, 11:39 Completed build in 12m 48s on Mon, 7 Sep, 11:39 AM Test Summary: 75107 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-778

  3. TYPO3com commented on patch set 1 09/07/20, 12:03 Completed build in 50m 11s on Mon, 7 Sep, 12:03 PM Test Summary: 75107 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-778

  4. Oliver Hader commented on patch set 1 09/07/20, 12:13

    I don't know what's going on/wrong here: https://bamboo.typo3.com/browse/CORE-GTC95-JSUT-778/log
  5. Oliver Hader uploaded patch set 2 09/07/20, 16:00

  6. Oliver Hader commented on patch set 2 09/07/20, 16:00

    Removed the tests... dunno
  7. TYPO3com voted on patch set 2 V +1 09/07/20, 16:14 Completed build in 14m 11s on Mon, 7 Sep, 04:14 PM Test Summary: 75178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-780

  8. Oliver Hader voted on patch set 2 V +2 CR +2 09/07/20, 16:41

  9. Oliver Hader merged patch set 3 09/07/20, 16:41