Review main Merged

65617[BUGFIX] PlainDataResolver misses DeletedRestriction

Christian Kuhn CR +2 V +2 Hard +212 −52 updated 09/07/20, 14:38

Commit message

The PlainDataResolver is used to find overlay id's of live
id's in workspace context. One usage is the ReferenceIndex.

In scenarios 'modify content, discard content, modify again'
with relations, the PlainDataResolver sometimes fetches rows
that have been set to deleted (discarded) already together
with the rows that should be fetched. Depending on the order
of the result rows - which depends on the DBMS - wrong overlay
rows are calculated sometimes.

The patch adds a database DeletedRestriction at 3 of 4 places
in the PlainDataResolver to only fetch correct rows. The last
place triggers another side-effect that needs to be tackled
with another patch and is commented as @todo for now.

The tests add missing sys_refindex rows to the 6 tests that
failed on postgres before. Additionally, for some other
IRRE/CSV workspace tests, the sys_refindex changes slightly
and is more correct now.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 19

Review log 712

  1. Christian Kuhn uploaded patch set 1 09/07/20, 11:46

  2. TYPO3com voted on patch set 1 V -1 09/07/20, 11:59 Completed build in 12m 55s on Mon, 7 Sep, 11:59 AM Test Summary: 36 of 73712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5320

  3. Christian Kuhn uploaded patch set 2 09/07/20, 12:40

  4. TYPO3com voted on patch set 2 V -1 09/07/20, 12:51 Completed build in 11m 01s on Mon, 7 Sep, 12:51 PM Test Summary: 40 of 73712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5323

  5. Christian Kuhn uploaded patch set 3 09/07/20, 13:36

  6. TYPO3com voted on patch set 3 V +1 09/07/20, 13:47 Completed build in 11m 14s on Mon, 7 Sep, 01:47 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5325

  7. Christian Kuhn updated the commit message in patch set 4 09/07/20, 13:54

  8. TYPO3com voted on patch set 4 V -1 09/07/20, 14:14 Completed build in 18m 35s on Mon, 7 Sep, 02:14 PM Test Summary: 2 of 73712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5327

  9. TYPO3com voted on patch set 4 V +1 09/07/20, 14:20 Completed build in 43m 31s on Mon, 7 Sep, 02:20 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5327

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 09/07/20, 14:31

  11. Anja Leichsenring voted on patch set 4 V +2 CR +2 09/07/20, 14:37

  12. Anja Leichsenring merged patch set 5 09/07/20, 14:38