Review main Merged

65618[BUGFIX] Add null coalesce operator for stdWrapValue second parameter

Nikita Hovratov CR +2 V +2 Hard +128 −128 updated 09/07/20, 16:18

Commit message

In some setups the conf array is null and throws an error. This patch
adds the ?? operator with an empty array as fallback value.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 3

Files 23

Show 3 more files

Review log 1013

  1. Nikita Hovratov uploaded patch set 1 09/07/20, 13:41

  2. TYPO3com voted on patch set 1 V +1 09/07/20, 13:53 Completed build in 12m 10s on Mon, 7 Sep, 01:53 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5326

  3. Nikita Hovratov uploaded patch set 2 09/07/20, 13:56

  4. Oliver Klee commented on patch set 2 09/07/20, 13:59

    Will PHPStan catch the problems that this change set resolves? Or do we need tests to make sure that the changes work as intended?
  5. Oliver Klee commented on patch set 2 CR -1 09/07/20, 14:01

    Unresolved

    The "Releases:" entry is missing here. Should this be master and 10.4? Or also 9.5?
  6. Nikita Hovratov updated the commit message in patch set 3 09/07/20, 14:02

  7. TYPO3com voted on patch set 2 V +1 09/07/20, 14:22 Completed build in 15m 47s on Mon, 7 Sep, 02:22 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5328

  8. TYPO3com voted on patch set 3 V +1 09/07/20, 14:26 Completed build in 20m 20s on Mon, 7 Sep, 02:26 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5329

  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 09/07/20, 14:39

  10. Oliver Klee commented on patch set 3 09/07/20, 15:06

    No 10.4?
  11. Nikita Hovratov commented on patch set 3 09/07/20, 16:02

    > Patch Set 3: > > (1 comment)

    Reply Unresolved

    The original patches what this fix is for, were also only for master.
  12. Benni Mack voted on patch set 3 V +2 CR +2 09/07/20, 16:18

  13. Benni Mack merged patch set 4 09/07/20, 16:18