65618[BUGFIX] Add null coalesce operator for stdWrapValue second parameter
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Benni Mack +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 3
Files 23
- typo3/sysext/extbase/Classes/Configuration/AbstractConfigurationManager.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+6 −6
- typo3/sysext/frontend/Classes/ContentObject/Menu/CategoryMenuUtility.php+3 −3
- typo3/sysext/frontend/Classes/ContentObject/Menu/TextMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/CaseContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+3 −3
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectArrayContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+49 −49
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php+5 −5
- typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php+5 −5
- typo3/sysext/frontend/Classes/ContentObject/HierarchicalMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+8 −8
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+5 −5
- typo3/sysext/frontend/Classes/ContentObject/ScalableVectorGraphicsContentObject.php+5 −5
- typo3/sysext/frontend/Classes/DataProcessing/CommaSeparatedValueProcessor.php+1 −1
- typo3/sysext/frontend/Classes/DataProcessing/DatabaseQueryProcessor.php+1 −1
- typo3/sysext/frontend/Classes/DataProcessing/FilesProcessor.php+6 −6
- typo3/sysext/frontend/Classes/DataProcessing/LanguageMenuProcessor.php+2 −2
- typo3/sysext/frontend/Classes/DataProcessing/SplitProcessor.php+1 −1
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+1 −1
Review log 1013
-
Nikita Hovratov uploaded patch set 1 09/07/20, 13:41
-
TYPO3com voted on patch set 1 V +1 09/07/20, 13:53 Completed build in 12m 10s on Mon, 7 Sep, 01:53 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5326
-
Nikita Hovratov uploaded patch set 2 09/07/20, 13:56
-
Oliver Klee commented on patch set 2 09/07/20, 13:59
Will PHPStan catch the problems that this change set resolves? Or do we need tests to make sure that the changes work as intended? -
Oliver Klee commented on patch set 2 CR -1 09/07/20, 14:01
Unresolved
The "Releases:" entry is missing here. Should this be master and 10.4? Or also 9.5? -
Nikita Hovratov updated the commit message in patch set 3 09/07/20, 14:02
-
TYPO3com voted on patch set 2 V +1 09/07/20, 14:22 Completed build in 15m 47s on Mon, 7 Sep, 02:22 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5328
-
TYPO3com voted on patch set 3 V +1 09/07/20, 14:26 Completed build in 20m 20s on Mon, 7 Sep, 02:26 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5329
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 09/07/20, 14:39
-
Oliver Klee commented on patch set 3 09/07/20, 15:06
No 10.4? -
Nikita Hovratov commented on patch set 3 09/07/20, 16:02
> Patch Set 3: > > (1 comment)Reply Unresolved
The original patches what this fix is for, were also only for master. -
Benni Mack voted on patch set 3 V +2 CR +2 09/07/20, 16:18
-
Benni Mack merged patch set 4 09/07/20, 16:18