Review 9.5 Merged

65620[TASK] Clean up JavaScript code

Oliver Hader CR +2 V +2 Easy +8 −8 updated 09/07/20, 18:49

Commit message

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Björn Jacob +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Björn Jacob +1
    • Andreas Kienast +1

Issues 1

Files 2

Review log 1317

  1. Oliver Hader uploaded patch set 1 09/07/20, 15:58

  2. TYPO3com voted on patch set 1 V -1 09/07/20, 16:12 Completed build in 13m 28s on Mon, 7 Sep, 04:12 PM Test Summary: 1 of 75778 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-779

  3. Oliver Hader updated the commit message in patch set 2 09/07/20, 16:43

  4. Oliver Hader rebased onto patch set 3 09/07/20, 16:43

  5. TYPO3com voted on patch set 1 V +1 09/07/20, 16:44 Completed build in 59m 07s on Mon, 7 Sep, 04:44 PM Test Summary: 75176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-779

  6. TYPO3com voted on patch set 3 V +1 09/07/20, 16:57 Completed build in 13m 44s on Mon, 7 Sep, 04:57 PM Test Summary: 75178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-783

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 09/07/20, 17:25

  8. Björn Jacob voted on patch set 3 V +1 CR +1 09/07/20, 17:41

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 09/07/20, 17:49

  10. Andreas Kienast commented on patch set 3 V 0 CR -1 09/07/20, 18:26

    This patch says "Releases: master" but was pushed to 9.5 branch.
  11. Oliver Hader voted on patch set 3 CR -1 09/07/20, 18:27

  12. Andreas Kienast updated the commit message in patch set 4 09/07/20, 18:35

  13. Andreas Kienast voted on patch set 4 V +1 CR +1 09/07/20, 18:35

  14. Björn Jacob voted on patch set 4 V +1 CR +1 09/07/20, 18:36

  15. Richard Haeser voted on patch set 4 V +2 CR +2 09/07/20, 18:47

  16. Richard Haeser merged patch set 5 09/07/20, 18:47

  17. TYPO3com voted on patch set 4 V +1 09/07/20, 18:49 Completed build in 13m 52s on Mon, 7 Sep, 06:49 PM Test Summary: 75178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-785