Review 9.5 Merged

65621[TASK] Add tests for SecurityUtility.getRandomHexValue

Oliver Hader CR +2 V +2 Normal +64 −4 updated 09/07/20, 21:45

Commit message

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 811

  1. Oliver Hader uploaded patch set 1 09/07/20, 16:04

  2. Oliver Hader rebased onto patch set 2 09/07/20, 18:27

  3. TYPO3com voted on patch set 2 V -1 09/07/20, 18:42 Completed build in 14m 13s on Mon, 7 Sep, 06:42 PM Test Summary: 75113 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-784

  4. Andreas Kienast rebased onto patch set 3 09/07/20, 18:54

  5. TYPO3com voted on patch set 3 V -1 09/07/20, 19:20 Completed build in 21m 24s on Mon, 7 Sep, 07:20 PM Test Summary: 75107 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-788

  6. Andreas Kienast commented on patch set 3 CR -1 09/07/20, 19:27

    on it

    SecurityUtilityTest.ts:18 Unresolved

    It seems the generators cause issues with TS 2.4
  7. Andreas Kienast uploaded patch set 4 09/07/20, 20:21

  8. Andreas Kienast voted on patch set 4 V +1 CR +1 09/07/20, 20:27

  9. TYPO3com voted on patch set 4 V +1 09/07/20, 20:38 Completed build in 14m 49s on Mon, 7 Sep, 08:38 PM Test Summary: 75180 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-789

  10. Oliver Hader voted on patch set 4 V +2 CR +2 09/07/20, 21:45

  11. Oliver Hader merged patch set 5 09/07/20, 21:45