Review main Abandoned

65622[FEATURE] Incremental link checking

Sybille Peters CR 0 V 0 Hard +276 −14 updated 06/22/21, 05:43

Commit message

The scheduler task for checking links with linkvalidator now
has an additional configuration option to set the "Check interval".
If this is not empty, linkvalidator only checks records that have
been changed within this time interval, for example "1d" which
means "one day".

This way, unnecessary checks on unchanged records can be
reduced.

TODOS:

- For the existing links in tx_linkvalidator_links it should also
  be checked if they apply - even if a link is not in a record
  that changed recently, the target may have change, e.g. a
  page was changed from hidden to unhidden etc.
- Add tests

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 11

Review log 2135

Show 510 earlier messages
  1. Sybille Peters uploaded patch set 1 09/07/20, 16:04

  2. TYPO3com voted on patch set 1 V -1 09/07/20, 16:24 Completed build in 18m 19s on Mon, 7 Sep, 04:24 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5334

  3. Sybille Peters uploaded patch set 2 09/07/20, 17:32

  4. TYPO3com voted on patch set 2 V -1 09/07/20, 17:55 Completed build in 14m 37s on Mon, 7 Sep, 05:55 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5342

  5. TYPO3com commented on patch set 2 09/16/20, 17:30 Completed build in 10m 31s on Wed, 16 Sep, 05:30 PM Test Summary: 73287 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5649

  6. Sybille Peters rebased onto patch set 3 09/17/20, 17:48

  7. TYPO3com voted on patch set 3 V -1 09/17/20, 18:01 Completed build in 13m 22s on Thu, 17 Sep, 06:01 PM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5686

  8. Sybille Peters uploaded patch set 4 09/18/20, 16:46

  9. TYPO3com voted on patch set 4 V +1 09/18/20, 16:58 Completed build in 11m 54s on Fri, 18 Sep, 04:58 PM Test Summary: 73281 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5730

  10. Sybille Peters uploaded patch set 5 09/20/20, 14:35

  1. TYPO3com voted on patch set 5 V +1 09/20/20, 14:48 Completed build in 12m 26s on Sun, 20 Sep, 02:48 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5765

  2. Sybille Peters uploaded patch set 6 09/20/20, 15:44

  3. Sybille Peters updated the commit message in patch set 7 09/20/20, 15:47

  4. TYPO3com voted on patch set 6 V -1 09/20/20, 15:57 Completed build in 12m 48s on Sun, 20 Sep, 03:57 PM Test Summary: 73315 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5768

  5. TYPO3com voted on patch set 7 V -1 09/20/20, 16:04 Completed build in 16m 20s on Sun, 20 Sep, 04:03 PM Test Summary: 9 of 74146 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5769

  6. TYPO3com voted on patch set 7 V +1 09/20/20, 16:45 Completed build in 11m 30s on Sun, 20 Sep, 04:45 PM Test Summary: 73661 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5771

  7. TYPO3com commented on patch set 7 09/20/20, 16:51 Completed build in 11m 41s on Sun, 20 Sep, 04:51 PM Test Summary: 73661 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5772

  8. Oli Bartsch commented on patch set 7 V -1 09/21/20, 08:02

    Really nice feature. Would you be fine with waiting until the general task improvement got merged? I can also provide the adjustments then.

    Feature-92220-IncrementalLinkCheckingForLinkvalidator.rst:34 Unresolved

    "will be ?" :) I tested it with "send email on broken links only" checked. Adding a new broken link, setting the check interval to something like 2 seconds works as expected. I don't get an email in this case. After switching to something like 10m I receive an email, also correct, but with all broken links not only those added in the last 10m. Is this the correct behaviour?

    LinkAnalyzer.php:178

    Unnecessary as you initialize it in the next line anyways. Maybe also use $constraints as name.

    ValidatorTask.php:99

    Strange that cgl is not complaining about the missing whitespace here.

    ValidatorTask.php:178

    Maybe add guard clause instead of if/else

    ValidatorTask.php:183

    getCheckIntervalInSeconds and setCheckIntervalInSeconds should be removed as they are never used.

    ValidatorTask.php:414

    Maybe add some whitespace between the operator. This first looked like a syntax error to me.

    ValidatorTask.php:655

    As the getter doesn't contain further processing we should directly use the class property `$this->checkInterval`

    ValidatorTaskAdditionalFieldProvider.php:191

    Label says "30" but actually 3600 is added here.

    ValidatorTaskAdditionalFieldProvider.php:304

    Ifs could be merged
  9. Sybille Peters commented on patch set 7 09/21/20, 09:22

    > Patch Set 7: Verified-1 > > (9 comments) > > Really nice feature. Would you be fine with waiting until the general task improvement got merged? I can also provide the adjustments then. Of course! I think it will be easier to rebase my patch than rebase yours. I will look at your other suggestions later.
  10. Sybille Peters uploaded patch set 8 09/24/20, 17:20

  11. TYPO3com voted on patch set 8 V +1 09/24/20, 17:32 Completed build in 11m 20s on Thu, 24 Sep, 05:32 PM Test Summary: 73708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5923

  12. Sybille Peters commented on patch set 8 CR -1 09/24/20, 17:50

    Working on it.

    LinkAnalyzer.php:178 Reply

    Done

    ValidatorTask.php:178 Reply

    Done

    ValidatorTask.php:183 Reply

    Done

    ValidatorTask.php:414 Reply

    Done
  13. Sybille Peters commented on patch set 8 09/24/20, 17:55

    ValidatorTask.php:99 Reply

    Done

    ValidatorTask.php:655 Reply

    Done

    ValidatorTaskAdditionalFieldProvider.php:191 Reply

    Done

    ValidatorTaskAdditionalFieldProvider.php:304 Reply

    Done
  14. Sybille Peters uploaded patch set 9 09/24/20, 17:56

  15. Sybille Peters uploaded patch set 10 09/24/20, 17:57

  16. Sybille Peters voted on patch set 10 CR -1 09/24/20, 17:57

  17. TYPO3com voted on patch set 10 V -1 09/24/20, 17:58 Completed build in 32s on Thu, 24 Sep, 05:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5925

  18. TYPO3com commented on patch set 9 09/24/20, 18:08 Completed build in 11m 55s on Thu, 24 Sep, 06:08 PM Test Summary: 73708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5924

  19. Sybille Peters wrote 10/23/20, 17:17

    Topic set to Linkvalidator
  20. Sybille Peters uploaded patch set 11 10/25/20, 13:36

  21. TYPO3com voted on patch set 11 V -1 10/25/20, 13:36 Completed build in 23s on Sun, 25 Oct, 01:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6873

  22. Sybille Peters commented on patch set 11 10/25/20, 13:37

    This needs more work and should possibly be abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/66279 (link target cache)
  23. Sybille Peters marked it work in progress 10/25/20, 18:09

  24. Stephan Großberndt commented on patch set 11 06/21/21, 23:27

    This change is ready for review.
    should this patch be abandoned as well?
  25. Sybille Peters abandoned the change 06/22/21, 05:43