65622[FEATURE] Incremental link checking
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 11
- Build/Sources/TypeScript/scheduler/Resources/Public/TypeScript/Scheduler.ts+7 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-92220-IncrementalLinkCheckingForLinkvalidator.rst1new+38 −0
- typo3/sysext/linkvalidator/Classes/Result/LinkAnalyzerResult.php+7 −2
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php10+53 −0
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php4+45 −0
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php2+27 −11
- typo3/sysext/linkvalidator/Resources/Private/Language/locallang.xlf+20 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_output_content_with_broken_links_timestamp.csvnew+3 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/input_content_with_broken_links_timestamp.xmlnew+23 −0
- typo3/sysext/linkvalidator/Tests/Functional/LinkAnalyzerTest.php+52 −0
- typo3/sysext/scheduler/Resources/Public/JavaScript/Scheduler.js+1 −1
Review log 2135
Show 510 earlier messages
-
Sybille Peters uploaded patch set 1 09/07/20, 16:04
-
TYPO3com voted on patch set 1 V -1 09/07/20, 16:24 Completed build in 18m 19s on Mon, 7 Sep, 04:24 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5334
-
Sybille Peters uploaded patch set 2 09/07/20, 17:32
-
TYPO3com voted on patch set 2 V -1 09/07/20, 17:55 Completed build in 14m 37s on Mon, 7 Sep, 05:55 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5342
-
TYPO3com commented on patch set 2 09/16/20, 17:30 Completed build in 10m 31s on Wed, 16 Sep, 05:30 PM Test Summary: 73287 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5649
-
Sybille Peters rebased onto patch set 3 09/17/20, 17:48
-
TYPO3com voted on patch set 3 V -1 09/17/20, 18:01 Completed build in 13m 22s on Thu, 17 Sep, 06:01 PM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5686
-
Sybille Peters uploaded patch set 4 09/18/20, 16:46
-
TYPO3com voted on patch set 4 V +1 09/18/20, 16:58 Completed build in 11m 54s on Fri, 18 Sep, 04:58 PM Test Summary: 73281 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5730
-
Sybille Peters uploaded patch set 5 09/20/20, 14:35
-
TYPO3com voted on patch set 5 V +1 09/20/20, 14:48 Completed build in 12m 26s on Sun, 20 Sep, 02:48 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5765
-
Sybille Peters uploaded patch set 6 09/20/20, 15:44
-
Sybille Peters updated the commit message in patch set 7 09/20/20, 15:47
-
TYPO3com voted on patch set 6 V -1 09/20/20, 15:57 Completed build in 12m 48s on Sun, 20 Sep, 03:57 PM Test Summary: 73315 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5768
-
TYPO3com voted on patch set 7 V -1 09/20/20, 16:04 Completed build in 16m 20s on Sun, 20 Sep, 04:03 PM Test Summary: 9 of 74146 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5769
-
TYPO3com voted on patch set 7 V +1 09/20/20, 16:45 Completed build in 11m 30s on Sun, 20 Sep, 04:45 PM Test Summary: 73661 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5771
-
TYPO3com commented on patch set 7 09/20/20, 16:51 Completed build in 11m 41s on Sun, 20 Sep, 04:51 PM Test Summary: 73661 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5772
-
Oli Bartsch commented on patch set 7 V -1 09/21/20, 08:02
Really nice feature. Would you be fine with waiting until the general task improvement got merged? I can also provide the adjustments then.Feature-92220-IncrementalLinkCheckingForLinkvalidator.rst:34Unresolved"will be ?" :) I tested it with "send email on broken links only" checked. Adding a new broken link, setting the check interval to something like 2 seconds works as expected. I don't get an email in this case. After switching to something like 10m I receive an email, also correct, but with all broken links not only those added in the last 10m. Is this the correct behaviour?LinkAnalyzer.php:178Unnecessary as you initialize it in the next line anyways. Maybe also use $constraints as name.ValidatorTask.php:99Strange that cgl is not complaining about the missing whitespace here.ValidatorTask.php:178Maybe add guard clause instead of if/elseValidatorTask.php:183getCheckIntervalInSeconds and setCheckIntervalInSeconds should be removed as they are never used.ValidatorTask.php:414Maybe add some whitespace between the operator. This first looked like a syntax error to me.ValidatorTask.php:655As the getter doesn't contain further processing we should directly use the class property `$this->checkInterval`ValidatorTaskAdditionalFieldProvider.php:191Label says "30" but actually 3600 is added here.ValidatorTaskAdditionalFieldProvider.php:304Ifs could be merged -
Sybille Peters commented on patch set 7 09/21/20, 09:22
> Patch Set 7: Verified-1 > > (9 comments) > > Really nice feature. Would you be fine with waiting until the general task improvement got merged? I can also provide the adjustments then. Of course! I think it will be easier to rebase my patch than rebase yours. I will look at your other suggestions later. -
Sybille Peters uploaded patch set 8 09/24/20, 17:20
-
TYPO3com voted on patch set 8 V +1 09/24/20, 17:32 Completed build in 11m 20s on Thu, 24 Sep, 05:32 PM Test Summary: 73708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5923
-
Sybille Peters commented on patch set 8 CR -1 09/24/20, 17:50
Working on it.LinkAnalyzer.php:178ReplyDoneValidatorTask.php:178ReplyDoneValidatorTask.php:183ReplyDoneValidatorTask.php:414ReplyDone -
Sybille Peters commented on patch set 8 09/24/20, 17:55
ValidatorTask.php:99ReplyDoneValidatorTask.php:655ReplyDoneValidatorTaskAdditionalFieldProvider.php:191ReplyDoneValidatorTaskAdditionalFieldProvider.php:304ReplyDone -
Sybille Peters uploaded patch set 9 09/24/20, 17:56
-
Sybille Peters uploaded patch set 10 09/24/20, 17:57
-
Sybille Peters voted on patch set 10 CR -1 09/24/20, 17:57
-
TYPO3com voted on patch set 10 V -1 09/24/20, 17:58 Completed build in 32s on Thu, 24 Sep, 05:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5925
-
TYPO3com commented on patch set 9 09/24/20, 18:08 Completed build in 11m 55s on Thu, 24 Sep, 06:08 PM Test Summary: 73708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5924
-
Sybille Peters wrote 10/23/20, 17:17
Topic set to Linkvalidator -
Sybille Peters uploaded patch set 11 10/25/20, 13:36
-
TYPO3com voted on patch set 11 V -1 10/25/20, 13:36 Completed build in 23s on Sun, 25 Oct, 01:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6873
-
Sybille Peters commented on patch set 11 10/25/20, 13:37
This needs more work and should possibly be abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/66279 (link target cache) -
Sybille Peters marked it work in progress 10/25/20, 18:09
-
Stephan Großberndt commented on patch set 11 06/21/21, 23:27
This change is ready for review.should this patch be abandoned as well? -
Sybille Peters abandoned the change 06/22/21, 05:43