65625[TASK] Replace ResponseError with regular AjaxResponse
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Richard Haeser +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Richard Haeser +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 35
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/Ajax/AjaxRequest.ts+1 −2
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/Ajax/AjaxResponse.ts3+31 −5
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/Ajax/ResponseError.ts+3 −0
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/Ajax/SimpleResponseInterface.tsnew+5 −0
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/BackwardCompat/JQueryNativePromises.ts+2 −2
- Build/Sources/TypeScript/extensionmanager/Resources/Public/TypeScript/Update.ts+1 −2
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Environment/EnvironmentCheck.ts+1 −2
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Environment/FolderStructure.ts+2 −3
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Environment/ImageProcessing.ts+2 −3
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Environment/MailTest.ts+1 −2
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Environment/PhpInfo.ts+1 −2
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Environment/SystemInformation.ts+1 −2
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Maintenance/ClearTables.ts+2 −3
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Maintenance/ClearTypo3tempFiles.ts+2 −3
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Maintenance/CreateAdmin.ts+2 −3
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Maintenance/DatabaseAnalyzer.ts+3 −4
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Maintenance/LanguagePacks.ts+4 −5
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Settings/ChangeInstallToolPassword.ts+2 −3
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Settings/ExtensionConfiguration.ts+2 −3
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Settings/Features.ts+2 −3
Show 15 more files
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Settings/LocalConfiguration.ts+2 −3
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Settings/Presets.ts+3 −4
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Settings/SystemMaintainer.ts+2 −3
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Upgrade/CoreUpdate.ts+2 −3
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Upgrade/ExtensionCompatTester.ts+4 −5
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Upgrade/ExtensionScanner.ts+3 −4
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Upgrade/TcaExtTablesCheck.ts+1 −2
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Upgrade/TcaMigrationsCheck.ts+1 −2
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Upgrade/UpgradeDocs.ts+4 −5
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Upgrade/UpgradeWizards.ts+10 −11
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Router.ts+12 −13
- typo3/sysext/core/Documentation/Changelog/10.3/Feature-89738-ApiForAjaxRequests.rst+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Ajax/AjaxRequest.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Ajax/AjaxResponse.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Ajax/SimpleResponseInterface.jsnew+13 −0
Review log 912
-
Oliver Hader uploaded patch set 1 09/07/20, 17:28
-
TYPO3com voted on patch set 1 V +1 09/07/20, 17:40 Completed build in 11m 28s on Mon, 7 Sep, 05:40 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5340
-
Andreas Kienast commented on patch set 1 CR -1 09/07/20, 17:45
on itAjaxResponse.ts:14UnresolvedCan be simplified to `./SimpleResponseInterface`, which also allows better autocompletionAjaxResponse.ts:27Unresolvedtypeof this.resolvedBody !== 'undefined'AjaxResponse.ts:30UnresolvedWe may use null coalescing here as .get() return a string or null. This won't cover the case of an empty header, though. -
Andreas Kienast uploaded patch set 2 09/07/20, 17:48
-
Andreas Kienast voted on patch set 2 V +1 CR +1 09/07/20, 17:51
-
TYPO3com voted on patch set 2 V +1 09/07/20, 18:00 Completed build in 11m 29s on Mon, 7 Sep, 06:00 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5343
-
Oliver Hader uploaded patch set 3 09/07/20, 18:02
-
TYPO3com voted on patch set 3 V +1 09/07/20, 18:14 Completed build in 12m 17s on Mon, 7 Sep, 06:14 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5344
-
Andreas Kienast voted on patch set 3 V +1 CR +1 09/07/20, 18:25
-
Richard Haeser voted on patch set 3 V +1 CR +1 09/07/20, 18:38
-
Benni Mack voted on patch set 3 V +2 CR +2 09/07/20, 18:40
-
Benni Mack merged patch set 4 09/07/20, 18:40