Review main Merged

65625[TASK] Replace ResponseError with regular AjaxResponse

Oliver Hader CR +2 V +2 Normal +130 −110 updated 09/07/20, 18:40

Commit message

HTTP responses having a status code not in 200-299 are basically
still responses. In order to allow general response handling
ResponseError is dropped in favor of AjaxResponse.

Besides that `AjaxResponse.dereference()` has been introduced which
allows to forward relevant data (status, headers, body) in events or
broadcast messages to other `window` instances or frames.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 35

Show 15 more files

Review log 912

  1. Oliver Hader uploaded patch set 1 09/07/20, 17:28

  2. TYPO3com voted on patch set 1 V +1 09/07/20, 17:40 Completed build in 11m 28s on Mon, 7 Sep, 05:40 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5340

  3. Andreas Kienast commented on patch set 1 CR -1 09/07/20, 17:45

    on it

    AjaxResponse.ts:14 Unresolved

    Can be simplified to `./SimpleResponseInterface`, which also allows better autocompletion

    AjaxResponse.ts:27 Unresolved

    typeof this.resolvedBody !== 'undefined'

    AjaxResponse.ts:30 Unresolved

    We may use null coalescing here as .get() return a string or null. This won't cover the case of an empty header, though.
  4. Andreas Kienast uploaded patch set 2 09/07/20, 17:48

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 09/07/20, 17:51

  6. TYPO3com voted on patch set 2 V +1 09/07/20, 18:00 Completed build in 11m 29s on Mon, 7 Sep, 06:00 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5343

  7. Oliver Hader uploaded patch set 3 09/07/20, 18:02

  8. TYPO3com voted on patch set 3 V +1 09/07/20, 18:14 Completed build in 12m 17s on Mon, 7 Sep, 06:14 PM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5344

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 09/07/20, 18:25

  10. Richard Haeser voted on patch set 3 V +1 CR +1 09/07/20, 18:38

  11. Benni Mack voted on patch set 3 V +2 CR +2 09/07/20, 18:40

  12. Benni Mack merged patch set 4 09/07/20, 18:40