Review 10.4 Merged

65628[BUGFIX] Update ref-index when deleting new workspace relations

Christian Kuhn CR +2 V +2 Hard +131 −171 updated 09/07/20, 21:01

Commit message

Adding an image to a workspace content element adds two
sys_refindex entries: One for the sys_file_reference
t3ver_state=-1 and one for the t3ver_state=1 record.

Deleting the image reference again in workspaces only sets
one of the two to deleted in sys_refindex, leading to orphan
sys_refindex entries.

The patch fixes this by adding a 'redo refindex' call at the
appropriate place.

There are more issues when 'discard changes' is used together with
multi-level relations (tt_content->hotel->offer->price): Discard
does not properly cascade in those cases, yet. The patch touches
this as a side-effect and does not improve the situation. The .csv
files are marked with @todo accordingly and will be fixed with further
patches. Those scenarios are more seldom than a broken sys_refindex
for FAL images which is the primary goal of this patch.

Analyzing the test scenarios, the patch actually removes various
rows from sys_refindex where the left part of the relation is set
to deleted. This is correct and wanted: In the end we don't want
sys_refindex to contain reference to deleted rows at all. This
strategy will be further followed with other patches.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 2

Files 41

Show 21 more files

Review log 57

  1. Christian Kuhn uploaded patch set 1 09/07/20, 20:36

  2. Christian Kuhn uploaded patch set 2 09/07/20, 20:44

  3. TYPO3com voted on patch set 1 V -1 09/07/20, 20:48 Completed build in 11m 56s on Mon, 7 Sep, 08:48 PM Test Summary: 81 of 74675 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-361

  4. TYPO3com voted on patch set 2 V +1 09/07/20, 20:56 Completed build in 11m 40s on Mon, 7 Sep, 08:56 PM Test Summary: 74190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-362

  5. Benni Mack commented on patch set 2 09/07/20, 21:01

    merging this one as workspace-only change.
  6. Benni Mack voted on patch set 2 V +2 CR +2 09/07/20, 21:01

  7. Benni Mack merged patch set 3 09/07/20, 21:01