65635[BUGFIX] Add support for symfony/event-dispatcher-contracts v1
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Simon Gilli +1
- Richard Haeser +1
- Oliver Hader +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Simon Gilli +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1618
-
Benni Mack uploaded patch set 1 09/08/20, 09:40
-
Simon Gilli commented on patch set 1 09/08/20, 09:47
composer.lock:1913Seems this was not correctly locked, no need to increase the version here imho -
Simon Gilli commented on patch set 1 09/08/20, 09:52
The change looks fine, there is no diff between 1.x and 2.x see https://github.com/symfony/event-dispatcher-contracts/compare/v2.0.1...v1.1.1 -
TYPO3com voted on patch set 1 V +1 09/08/20, 09:52 Completed build in 11m 35s on Tue, 8 Sep, 09:52 AM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5359
-
Simon Gilli commented on patch set 1 V +1 CR -1 09/08/20, 10:04
Looks fine but see my comments -
Simon Gilli uploaded patch set 2 09/08/20, 10:16
-
Simon Gilli voted on patch set 2 V +1 CR +1 09/08/20, 10:18
-
Simon Gilli commented on patch set 2 09/08/20, 10:20
composer.lock:1913ReplyDone -
Georg Ringer commented on patch set 1 CR -1 09/08/20, 10:21
only tested in 10 and after applying the commands from commit msg, I still can't install "c req solarium/solarium:^4.2" -
Simon Gilli commented on patch set 2 09/08/20, 10:25
> Patch Set 1: Code-Review-1 > > only tested in 10 and after applying the commands from commit msg, I still can't install "c req solarium/solarium:^4.2" Will check again with your setup, should work imho.... -
TYPO3com voted on patch set 2 V +1 09/08/20, 10:27 Completed build in 10m 39s on Tue, 8 Sep, 10:27 AM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5361
-
Simon Gilli commented on patch set 2 09/08/20, 10:41
> Patch Set 2: > > > Patch Set 1: Code-Review-1 > > > > only tested in 10 and after applying the commands from commit msg, I still can't install "c req solarium/solarium:^4.2" > > Will check again with your setup, should work imho.... Tested again and I was able to require solarium/solarium:^4.2. Perhaps your existing composer.lock and/or vendor folder blocks you... -
Oliver Hader voted on patch set 2 CR +1 09/08/20, 10:50
-
Georg Ringer voted on patch set 2 V +1 CR +1 09/08/20, 11:01
-
Richard Haeser voted on patch set 2 CR +1 09/08/20, 11:13
-
Benjamin Franzke commented on patch set 2 V +2 CR +2 09/08/20, 13:59
Yea, so the issue isn't directly that event-dispatcher-contracts v2.0 isn't v4 compatible (there is NO difference between v1 and v2), but that symfony v4 pulls in version 1.0 and doesn't pull in v2. What a mess: https://packagist.org/packages/symfony/event-dispatcher#v4.4.13 IMO https://packagist.org/packages/symfony/event-dispatcher-contracts should have defined a conflict against symfony v4, or symfony v4 should have been updated to be compatible with event-constracts v2 – anyway, this patch is fine. I tested with a composer based installation where installation against symfony v4 was successfull. -
Benjamin Franzke merged patch set 3 09/08/20, 14:00
-
Simon Gilli commented on patch set 3 09/08/20, 20:21
https://github.com/symfony/event-dispatcher-contracts/compare/v1.1.1...v2.2.0 delivers a complete other result than my tested link before https://github.com/symfony/event-dispatcher-contracts/compare/v2.0.1...v1.1.1. This patch needs to be reverted because it's not working properly!
Unresolved