Review main Merged

65636[BUGFIX] Make external link checking more robust

Sybille Peters CR +2 V +2 Easy +20 −4 updated 09/11/20, 06:36

Commit message

Previously, some URLs could result in errors which were not caught and
caused the link checking task to abort.

ExternalLinktype::preprocessUrl() now returns original URL in case
of any error, catches errors and exception and does some sanity
checking of parsed URLs before using the results.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Sybille Peters uploaded patch set 1 09/08/20, 12:51

  2. Sybille Peters updated the commit message in patch set 2 09/08/20, 12:55

  3. TYPO3com voted on patch set 1 V +1 09/08/20, 13:03 Completed build in 11m 48s on Tue, 8 Sep, 01:03 PM Test Summary: 73185 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5367

  4. TYPO3com voted on patch set 2 V +1 09/08/20, 13:08 Completed build in 12m 26s on Tue, 8 Sep, 01:08 PM Test Summary: 73185 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5368

  5. Jörg Bösche commented on patch set 2 CR -1 09/09/20, 07:17

    ExternalLinktype.php:288

    IMO, we should combine the exceptions to "catch(\Throwable | \Exception $e)".
  6. Sybille Peters commented on patch set 2 09/09/20, 08:49

    ExternalLinktype.php:288 Reply

    Didn't know you could do that. Like it.
  7. Sybille Peters uploaded patch set 3 09/09/20, 08:54

  8. Sybille Peters commented on patch set 3 09/09/20, 08:55

    > Patch Set 2: > > (1 comment) Done

    ExternalLinktype.php:288 Reply

    Done
  9. TYPO3com voted on patch set 3 V +1 09/09/20, 09:08 Completed build in 14m 22s on Wed, 9 Sep, 09:08 AM Test Summary: 73185 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5390

  10. Jörg Bösche voted on patch set 3 CR +1 09/09/20, 09:11

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 09/10/20, 10:23

  12. Benni Mack voted on patch set 3 V +2 CR +2 09/11/20, 06:36

  13. Benni Mack merged patch set 4 09/11/20, 06:36