Review main Merged

65638[BUGFIX] Separate 'delete' and 'discard' in DataHandler

Christian Kuhn CR +2 V +2 Nightmare +5405 −4407 updated 09/19/20, 12:38

Commit message

There are 4 "drop record" scenarios in workspaces:
* Delete a new or changed record in list/page module
* Create a delete placeholder in list/page module to mark a
  live record as to-be-deleted on workspace publish
* Discard (throw away) a change in workspace module
* Flush all workspace changes by deleting a sys_workspace
  record.

All these scenarios are handled with the same DataHandler
code which leads to tons of bugs since especially
"delete & create delete placeholder" compared to
"discard & flush" are logically different things.

The patch separates discard and flush to a new codebase.
First patch sets started with a 1:1 copy of the delete code,
then carefully refactored the code to its final state. The
roughly 850 lines of delete code are streamlined to about
300 lines for discard and flush. The code is much easier
to follow, recursions are simplified and access checks are
in one place.

Discard previously created a mixture of hard and soft deleted
records in the database, leading to a huge mess. This changed:
Discard now always means that records are dropped from database.

The discard code now properly cascades down into relations,
solving tons of bugs along the way. The functional DataHandler
tests are refactored and heavily extended to cover discard.
Two previously existing issues are not fixed yet: ManyToMany
relations are not properly cleaned up on discard, and discarding
does not fully follow localization overlays in 'connected' mode.
Those scenarios are marked with @todo's in the .csv files and
should be relatively easy to solve with dedicated single patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 262

Show 242 more files

Review log 89171

Show 73146 earlier messages
  1. Christian Kuhn uploaded patch set 1 09/08/20, 13:21

  2. TYPO3com voted on patch set 1 V -1 09/08/20, 13:32 Completed build in 11m 01s on Tue, 8 Sep, 01:32 PM Test Summary: 6 of 73658 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5370

  3. Christian Kuhn uploaded patch set 2 09/09/20, 07:52

  4. TYPO3com voted on patch set 2 V -1 09/09/20, 08:04 Completed build in 12m 33s on Wed, 9 Sep, 08:04 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5386

  5. Christian Kuhn uploaded patch set 3 09/09/20, 20:47

  6. TYPO3com voted on patch set 3 V -1 09/09/20, 20:56 Completed build in 35s on Wed, 9 Sep, 08:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5449

  7. Christian Kuhn uploaded patch set 4 09/09/20, 21:02

  8. TYPO3com voted on patch set 4 V -1 09/09/20, 21:17 Completed build in 15m 47s on Wed, 9 Sep, 09:17 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5450

  9. Christian Kuhn uploaded patch set 5 09/09/20, 21:31

  10. Christian Kuhn uploaded patch set 6 09/09/20, 21:39

  11. TYPO3com voted on patch set 5 V -1 09/09/20, 21:47 Completed build in 15m 33s on Wed, 9 Sep, 09:47 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5452

  12. TYPO3com voted on patch set 6 V -1 09/09/20, 21:53 Completed build in 13m 39s on Wed, 9 Sep, 09:53 PM Test Summary: 135 of 73658 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5453

  13. Christian Kuhn uploaded patch set 7 09/09/20, 22:47

  14. TYPO3com voted on patch set 7 V -1 09/09/20, 23:04 Completed build in 15m 54s on Wed, 9 Sep, 11:04 PM Test Summary: 18 of 73658 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5456

  15. Christian Kuhn uploaded patch set 8 09/09/20, 23:26

  16. TYPO3com voted on patch set 8 V +1 09/09/20, 23:39 Completed build in 13m 18s on Wed, 9 Sep, 11:39 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5457

  17. Christian Kuhn uploaded patch set 9 09/09/20, 23:56

  18. TYPO3com voted on patch set 9 V -1 09/10/20, 00:09 Completed build in 12m 36s on Thu, 10 Sep, 12:09 AM Test Summary: 24 of 73658 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5458

  19. Christian Kuhn uploaded patch set 10 09/13/20, 10:08

  20. Christian Kuhn uploaded patch set 11 09/13/20, 10:19

  21. TYPO3com voted on patch set 10 V -1 09/13/20, 10:20 Completed build in 11m 12s on Sun, 13 Sep, 10:20 AM Test Summary: 81 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5571

  22. TYPO3com voted on patch set 11 V -1 09/13/20, 10:30 Completed build in 11m 21s on Sun, 13 Sep, 10:30 AM Test Summary: 81 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5572

  23. Christian Kuhn uploaded patch set 12 09/13/20, 10:56

  24. TYPO3com voted on patch set 12 V -1 09/13/20, 11:07 Completed build in 11m 04s on Sun, 13 Sep, 11:07 AM Test Summary: 6 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5573

  25. Christian Kuhn uploaded patch set 13 09/13/20, 11:08

  26. Christian Kuhn uploaded patch set 14 09/13/20, 11:16

  27. TYPO3com voted on patch set 13 V +1 09/13/20, 11:20 Completed build in 12m 07s on Sun, 13 Sep, 11:20 AM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5575

  28. TYPO3com voted on patch set 14 V +1 09/13/20, 11:28 Completed build in 12m 22s on Sun, 13 Sep, 11:28 AM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5576

  29. Christian Kuhn uploaded patch set 15 09/13/20, 11:29

  30. TYPO3com voted on patch set 15 V +1 09/13/20, 11:41 Completed build in 11m 32s on Sun, 13 Sep, 11:41 AM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5578

  31. Christian Kuhn uploaded patch set 16 09/13/20, 11:46

  32. TYPO3com voted on patch set 16 V +1 09/13/20, 11:58 Completed build in 11m 34s on Sun, 13 Sep, 11:58 AM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5579

  33. Christian Kuhn uploaded patch set 17 09/13/20, 12:03

  34. Christian Kuhn uploaded patch set 18 09/13/20, 12:12

  35. TYPO3com voted on patch set 17 V +1 09/13/20, 12:15 Completed build in 11m 50s on Sun, 13 Sep, 12:15 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5580

  36. Christian Kuhn uploaded patch set 19 09/13/20, 12:22

  37. TYPO3com voted on patch set 18 V +1 09/13/20, 12:24 Completed build in 12m 28s on Sun, 13 Sep, 12:24 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5581

  38. TYPO3com voted on patch set 19 V -1 09/13/20, 12:34 Completed build in 11m 44s on Sun, 13 Sep, 12:34 PM Test Summary: 54 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5582

  39. Christian Kuhn uploaded patch set 20 09/13/20, 13:15

  40. TYPO3com voted on patch set 20 V -1 09/13/20, 13:27 Completed build in 11m 57s on Sun, 13 Sep, 01:27 PM Test Summary: 45 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5583

  41. Christian Kuhn uploaded patch set 21 09/13/20, 13:37

  42. TYPO3com voted on patch set 21 V -1 09/13/20, 13:49 Completed build in 12m 00s on Sun, 13 Sep, 01:49 PM Test Summary: 33 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5584

  43. Christian Kuhn uploaded patch set 22 09/13/20, 14:22

  44. Christian Kuhn uploaded patch set 23 09/13/20, 14:33

  45. TYPO3com voted on patch set 22 V +1 09/13/20, 14:34 Completed build in 11m 52s on Sun, 13 Sep, 02:34 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5585

  46. TYPO3com voted on patch set 23 V +1 09/13/20, 14:45 Completed build in 11m 08s on Sun, 13 Sep, 02:45 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5586

  47. Christian Kuhn uploaded patch set 24 09/13/20, 16:19

  48. TYPO3com voted on patch set 24 V +1 09/13/20, 16:30 Completed build in 11m 05s on Sun, 13 Sep, 04:30 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5587

  49. Christian Kuhn uploaded patch set 25 09/13/20, 16:35

  50. TYPO3com voted on patch set 25 V +1 09/13/20, 16:47 Completed build in 11m 15s on Sun, 13 Sep, 04:46 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5588

  51. Christian Kuhn uploaded patch set 26 09/13/20, 17:22

  52. TYPO3com voted on patch set 26 V +1 09/13/20, 17:33 Completed build in 11m 06s on Sun, 13 Sep, 05:33 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5589

  53. Christian Kuhn uploaded patch set 27 09/14/20, 10:17

  54. TYPO3com voted on patch set 27 V -1 09/14/20, 10:28 Completed build in 11m 12s on Mon, 14 Sep, 10:28 AM Test Summary: 39 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5595

  55. Christian Kuhn uploaded patch set 28 09/14/20, 10:50

  56. TYPO3com voted on patch set 28 V -1 09/14/20, 11:02 Completed build in 11m 22s on Mon, 14 Sep, 11:02 AM Test Summary: 21 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5596

  57. Christian Kuhn uploaded patch set 29 09/14/20, 11:05

  58. Christian Kuhn uploaded patch set 30 09/14/20, 11:05

  59. Christian Kuhn uploaded patch set 31 09/14/20, 11:16

  60. TYPO3com voted on patch set 29 V -1 09/14/20, 11:17 Completed build in 11m 39s on Mon, 14 Sep, 11:17 AM Test Summary: 1 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5597

  61. TYPO3com voted on patch set 30 V +1 09/14/20, 11:22 Completed build in 16m 50s on Mon, 14 Sep, 11:22 AM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5598

  62. TYPO3com voted on patch set 31 V +1 09/14/20, 11:29 Completed build in 12m 01s on Mon, 14 Sep, 11:29 AM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5599

  63. Christian Kuhn uploaded patch set 32 09/14/20, 11:42

  64. TYPO3com voted on patch set 32 V -1 09/14/20, 11:54 Completed build in 11m 52s on Mon, 14 Sep, 11:54 AM Test Summary: 84 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5601

  65. Christian Kuhn uploaded patch set 33 09/14/20, 12:03

  66. TYPO3com voted on patch set 33 V +1 09/14/20, 12:14 Completed build in 10m 58s on Mon, 14 Sep, 12:14 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5602

  67. Christian Kuhn uploaded patch set 34 09/14/20, 12:18

  68. Christian Kuhn uploaded patch set 35 09/14/20, 12:23

  69. TYPO3com voted on patch set 34 V +1 09/14/20, 12:30 Completed build in 11m 43s on Mon, 14 Sep, 12:29 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5603

  70. TYPO3com voted on patch set 35 V -1 09/14/20, 12:38 Completed build in 14m 57s on Mon, 14 Sep, 12:38 PM Test Summary: 72554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5604

  71. TYPO3com voted on patch set 35 V +1 09/14/20, 12:43 Completed build in 35m 00s on Mon, 14 Sep, 12:43 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5604

  72. Christian Kuhn uploaded patch set 36 09/14/20, 12:52

  73. TYPO3com voted on patch set 36 V -1 09/14/20, 12:54 Completed build in 40s on Mon, 14 Sep, 12:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5605

  74. Christian Kuhn uploaded patch set 37 09/14/20, 12:57

  75. TYPO3com voted on patch set 37 V -1 09/14/20, 13:09 Completed build in 11m 45s on Mon, 14 Sep, 01:09 PM Test Summary: 6 of 73724 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5606

  76. Christian Kuhn uploaded patch set 38 09/14/20, 13:24

  77. Christian Kuhn uploaded patch set 39 09/14/20, 13:33

  78. TYPO3com voted on patch set 38 V +1 09/14/20, 13:36 Completed build in 11m 36s on Mon, 14 Sep, 01:36 PM Test Summary: 73239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5607

  79. TYPO3com voted on patch set 39 V +1 09/14/20, 13:44 Completed build in 11m 40s on Mon, 14 Sep, 01:44 PM Test Summary: 73239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5608

  80. Christian Kuhn uploaded patch set 40 09/15/20, 11:38

  81. TYPO3com voted on patch set 40 V -1 09/15/20, 11:39 Completed build in 31s on Tue, 15 Sep, 11:39 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5624

  82. Christian Kuhn uploaded patch set 41 09/15/20, 11:45

  83. Christian Kuhn uploaded patch set 42 09/15/20, 11:57

  84. TYPO3com voted on patch set 41 V -1 09/15/20, 11:58 Completed build in 12m 17s on Tue, 15 Sep, 11:58 AM Test Summary: 73406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5625

  85. TYPO3com voted on patch set 42 V +1 09/15/20, 12:14 Completed build in 17m 36s on Tue, 15 Sep, 12:14 PM Test Summary: 73406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5628

  86. Christian Kuhn uploaded patch set 43 09/15/20, 15:27

  87. TYPO3com voted on patch set 43 V +1 09/15/20, 15:40 Completed build in 11m 56s on Tue, 15 Sep, 03:40 PM Test Summary: 73415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5634

  88. Christian Kuhn uploaded patch set 44 09/15/20, 16:54

  89. TYPO3com voted on patch set 44 V +1 09/15/20, 17:06 Completed build in 11m 23s on Tue, 15 Sep, 05:06 PM Test Summary: 73424 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5635

  90. Christian Kuhn uploaded patch set 45 09/15/20, 17:58

  91. TYPO3com voted on patch set 45 V +1 09/15/20, 18:09 Completed build in 11m 24s on Tue, 15 Sep, 06:09 PM Test Summary: 73460 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5636

  92. Christian Kuhn uploaded patch set 46 09/15/20, 20:17

  93. TYPO3com voted on patch set 46 V +1 09/15/20, 20:33 Completed build in 15m 50s on Tue, 15 Sep, 08:33 PM Test Summary: 73511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5638

  94. Christian Kuhn uploaded patch set 47 09/16/20, 10:17

  95. TYPO3com voted on patch set 47 V +1 09/16/20, 10:28 Completed build in 11m 14s on Wed, 16 Sep, 10:28 AM Test Summary: 73586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5646

  96. Christian Kuhn uploaded patch set 48 09/16/20, 10:57

  97. TYPO3com voted on patch set 48 V +1 09/16/20, 11:09 Completed build in 11m 20s on Wed, 16 Sep, 11:09 AM Test Summary: 73634 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5647

  98. Christian Kuhn uploaded patch set 49 09/16/20, 11:39

  99. TYPO3com voted on patch set 49 V +1 09/16/20, 11:50 Completed build in 10m 47s on Wed, 16 Sep, 11:50 AM Test Summary: 73634 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5648

  100. Christian Kuhn uploaded patch set 50 09/17/20, 08:03

  101. TYPO3com voted on patch set 50 V +1 09/17/20, 08:17 Completed build in 14m 27s on Thu, 17 Sep, 08:17 AM Test Summary: 73634 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5656

  102. Christian Kuhn uploaded patch set 51 09/17/20, 08:32

  103. TYPO3com voted on patch set 51 V +1 09/17/20, 09:19 Completed build in 39m 53s on Thu, 17 Sep, 09:19 AM Test Summary: 73622 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5666

  104. Christian Kuhn uploaded patch set 52 09/17/20, 09:51

  105. TYPO3com voted on patch set 52 V -1 09/17/20, 10:03 Completed build in 11m 47s on Thu, 17 Sep, 10:03 AM Test Summary: 52 of 74107 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5668

  106. Christian Kuhn uploaded patch set 53 09/17/20, 10:47

  107. TYPO3com voted on patch set 53 V +1 09/17/20, 10:59 Completed build in 11m 03s on Thu, 17 Sep, 10:59 AM Test Summary: 73622 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5669

  108. Christian Kuhn uploaded patch set 54 09/17/20, 11:20

  109. Christian Kuhn uploaded patch set 55 09/17/20, 11:29

  110. TYPO3com voted on patch set 54 V -1 09/17/20, 11:34 Completed build in 14m 18s on Thu, 17 Sep, 11:34 AM Test Summary: 73622 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5670

  111. Christian Kuhn uploaded patch set 56 09/17/20, 11:36

  112. TYPO3com voted on patch set 55 V +1 09/17/20, 11:41 Completed build in 12m 09s on Thu, 17 Sep, 11:41 AM Test Summary: 73622 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5671

  113. TYPO3com voted on patch set 56 V +1 09/17/20, 11:48 Completed build in 12m 10s on Thu, 17 Sep, 11:48 AM Test Summary: 73622 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5672

  114. Christian Kuhn uploaded patch set 57 09/17/20, 11:50

  115. Christian Kuhn uploaded patch set 58 09/17/20, 11:57

  116. TYPO3com voted on patch set 57 V +1 09/17/20, 12:03 Completed build in 12m 58s on Thu, 17 Sep, 12:03 PM Test Summary: 73622 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5673

  117. TYPO3com voted on patch set 58 V +1 09/17/20, 12:09 Completed build in 12m 28s on Thu, 17 Sep, 12:09 PM Test Summary: 73622 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5674

  118. Christian Kuhn uploaded patch set 59 09/17/20, 13:35

  119. TYPO3com voted on patch set 59 V -1 09/17/20, 13:36 Completed build in 32s on Thu, 17 Sep, 01:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5676

  120. Christian Kuhn uploaded patch set 60 09/17/20, 13:37

  121. TYPO3com voted on patch set 60 V -1 09/17/20, 13:49 Completed build in 10m 55s on Thu, 17 Sep, 01:49 PM Test Summary: 15 of 74122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5677

  122. Christian Kuhn uploaded patch set 61 09/17/20, 13:56

  123. TYPO3com voted on patch set 61 V +1 09/17/20, 14:08 Completed build in 11m 20s on Thu, 17 Sep, 02:08 PM Test Summary: 73637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5678

  124. Christian Kuhn uploaded patch set 62 09/17/20, 14:26

  125. TYPO3com voted on patch set 62 V +1 09/17/20, 14:39 Completed build in 12m 38s on Thu, 17 Sep, 02:39 PM Test Summary: 73637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5679

  126. Christian Kuhn uploaded patch set 63 09/17/20, 16:12

  127. TYPO3com voted on patch set 63 V +1 09/17/20, 16:24 Completed build in 10m 59s on Thu, 17 Sep, 04:24 PM Test Summary: 73652 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5683

  128. Christian Kuhn uploaded patch set 64 09/17/20, 16:25

  129. TYPO3com voted on patch set 64 V +1 09/17/20, 16:36 Completed build in 10m 23s on Thu, 17 Sep, 04:36 PM Test Summary: 73652 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5684

  130. Christian Kuhn uploaded patch set 65 09/17/20, 18:05

  131. TYPO3com voted on patch set 65 V +1 09/17/20, 18:17 Completed build in 11m 39s on Thu, 17 Sep, 06:17 PM Test Summary: 73652 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5689

  132. Christian Kuhn uploaded patch set 66 09/17/20, 18:27

  133. TYPO3com voted on patch set 66 V +1 09/17/20, 18:42 Completed build in 12m 23s on Thu, 17 Sep, 06:42 PM Test Summary: 73652 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5692

  134. Christian Kuhn uploaded patch set 67 09/17/20, 19:18

  135. TYPO3com voted on patch set 67 V +1 09/17/20, 19:36 Completed build in 15m 33s on Thu, 17 Sep, 07:36 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5696

  136. Christian Kuhn uploaded patch set 68 09/17/20, 19:43

  137. Christian Kuhn uploaded patch set 69 09/17/20, 19:54

  138. TYPO3com voted on patch set 68 V +1 09/17/20, 19:54 Completed build in 11m 09s on Thu, 17 Sep, 07:54 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5697

  139. TYPO3com voted on patch set 69 V -1 09/17/20, 19:54 Completed build in 35s on Thu, 17 Sep, 07:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5698

  140. Christian Kuhn uploaded patch set 70 09/17/20, 19:58

  141. TYPO3com voted on patch set 70 V -1 09/17/20, 20:10 Completed build in 11m 25s on Thu, 17 Sep, 08:10 PM Test Summary: 9 of 74143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5699

  142. Christian Kuhn uploaded patch set 71 09/17/20, 20:15

  143. TYPO3com voted on patch set 71 V -1 09/17/20, 20:31 Completed build in 16m 23s on Thu, 17 Sep, 08:31 PM Test Summary: 9 of 74143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5700

  144. Christian Kuhn uploaded patch set 72 09/17/20, 20:49

  145. TYPO3com voted on patch set 72 V +1 09/17/20, 21:01 Completed build in 11m 45s on Thu, 17 Sep, 09:01 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5701

  146. Christian Kuhn uploaded patch set 73 09/17/20, 21:03

  1. TYPO3com voted on patch set 73 V -1 09/17/20, 21:03 Completed build in 41s on Thu, 17 Sep, 09:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5702

  2. Christian Kuhn uploaded patch set 74 09/17/20, 21:15

  3. TYPO3com voted on patch set 74 V -1 09/17/20, 21:32 Completed build in 17m 14s on Thu, 17 Sep, 09:32 PM Test Summary: 15 of 74143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5703

  4. Christian Kuhn uploaded patch set 75 09/17/20, 21:58

  5. Christian Kuhn uploaded patch set 76 09/17/20, 22:10

  6. TYPO3com voted on patch set 75 V +1 09/17/20, 22:12 Completed build in 13m 23s on Thu, 17 Sep, 10:12 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5704

  7. Christian Kuhn uploaded patch set 77 09/17/20, 22:20

  8. TYPO3com voted on patch set 76 V +1 09/17/20, 22:23 Completed build in 12m 40s on Thu, 17 Sep, 10:23 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5705

  9. TYPO3com voted on patch set 77 V +1 09/17/20, 22:33 Completed build in 12m 30s on Thu, 17 Sep, 10:33 PM Test Summary: 73656 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5706

  10. Christian Kuhn uploaded patch set 78 09/18/20, 08:42

  11. TYPO3com voted on patch set 78 V -1 09/18/20, 08:44 Completed build in 51s on Fri, 18 Sep, 08:44 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5711

  12. Christian Kuhn uploaded patch set 79 09/18/20, 09:53

  13. TYPO3com voted on patch set 79 V -1 09/18/20, 09:54 Completed build in 31s on Fri, 18 Sep, 09:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5712

  14. Christian Kuhn uploaded patch set 80 09/18/20, 10:00

  15. TYPO3com voted on patch set 80 V +1 09/18/20, 10:12 Completed build in 12m 14s on Fri, 18 Sep, 10:12 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5713

  16. Andreas Kienast commented on patch set 80 09/18/20, 14:37

    DataHandler.php:5364

    Annotation from PHP Inspections: [EA] Only local copy/reference will be unset. This unset can probably be removed. This affects $record and $uid

    DataHandler.php:5379

    Can be rewritten to $fullLanguageAccessCheck = !($table === 'pages' && (int)$versionRecord[$GLOBALS['TCA']['pages']['ctrl']['transOrigPointerField']] !== 0);

    DataHandler.php:5387

    Both if() can be merged

    DataHandler.php:5437

    I think this depends on the translation mode. If we keep localizations that may depend on new content in L=0 this would cause inconsistencies in connected mode.

    DataHandler.php:5464

    WorkspaceRestriction is not used on purpose?

    DataHandler.php:5499

    Personally, I'd use 'null' here as foreign_table is meant to be a string.

    DataHandler.php:5502

    `(bool)($fieldConfig['behaviour']['enableCascadingDelete'] ?? false) === false` would do the same.
  17. Christian Kuhn commented on patch set 80 09/18/20, 15:42

    DataHandler.php:5364 Reply

    Done

    DataHandler.php:5379 Reply

    Done

    DataHandler.php:5387 Reply

    Done

    DataHandler.php:5437 Reply Unresolved

    yeah. still, there is something todo in this case. i wanted to mark the place accordingly. we can sort out details with a dedicated patch.

    DataHandler.php:5464 Reply Unresolved

    yeah. ws restriction would also fetch live records. not wanted here.

    DataHandler.php:5499 Reply

    Done

    DataHandler.php:5502 Reply Unresolved

    nope. cascading true is default if array is not set or does not evaluate to false.
  18. Christian Kuhn uploaded patch set 81 09/18/20, 15:43

  19. TYPO3com voted on patch set 81 V +1 09/18/20, 15:55 Completed build in 11m 07s on Fri, 18 Sep, 03:55 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5724

  20. Oli Bartsch voted on patch set 81 V +1 CR +1 09/18/20, 16:14

  21. Anja Leichsenring voted on patch set 81 V +1 CR +1 09/18/20, 18:21

  22. Benni Mack commented on patch set 81 V +2 CR +2 09/18/20, 18:44

    nice work. I leave you the honor, Christian, to merge!
  23. Christian Kuhn voted on patch set 81 V +2 CR +2 09/18/20, 18:44

  24. Christian Kuhn merged patch set 82 09/18/20, 18:45

  25. Daniel Goerz commented on patch set 82 09/19/20, 12:38

    Chapeau!