65639[TASK] Avoid objectManager->get() in functional tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 40
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/BlogRepository.php+0 −12
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/class_overriding/a/Classes/Domain/Repository/ARepository.php+1 −4
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/class_overriding/a/Configuration/Services.yamlnew+11 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/class_overriding/a/ext_localconf.phpdeleted+0 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/class_overriding/b/Classes/Domain/Repository/BRepository.php+1 −4
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Domain/Validator/ModelValidator.phpdeleted+0 −33
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_argument_test/Classes/Controller/ArgumentTestController.phprenamed+9 −19
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_argument_test/Classes/Domain/Model/Model.phprenamed+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_argument_test/Classes/Domain/Model/ModelDto.phprenamed+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_argument_test/Classes/Domain/Validation/Validator/FailingValidator.phprenamed+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_argument_test/Configuration/Services.yamlnew+8 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_argument_test/Resources/Private/Templates/InputPresetDto.htmlrenamed+0 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_argument_test/Resources/Private/Templates/InputPresetModel.htmlrenamed+0 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_argument_test/ext_emconf.phpnew+21 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_test/Classes/Controller/TestController.phprenamed+3 −3
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_test/Classes/Domain/Model/Model.phpcopied+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_test/Configuration/Services.yamlnew+8 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_test/ext_emconf.phpnew+21 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+12 −25
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+23 −20
Show 20 more files
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ControllerArgumentsMappingTest.php+4 −6
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+7 −18
- typo3/sysext/extbase/Tests/Functional/Mvc/Web/RequestBuilderTest.php+20 −41
- typo3/sysext/extbase/Tests/Functional/Pagination/QueryResultPaginatorTest.php+1 −6
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapFactoryTest.php+2 −12
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php+2 −12
- typo3/sysext/extbase/Tests/Functional/Persistence/AddTest.php+8 −20
- typo3/sysext/extbase/Tests/Functional/Persistence/CountTest.php+4 −26
- typo3/sysext/extbase/Tests/Functional/Persistence/ImplementationClassNameTest.php+4 −16
- typo3/sysext/extbase/Tests/Functional/Persistence/InTest.php+7 −15
- typo3/sysext/extbase/Tests/Functional/Persistence/IsDirtyTest.php+4 −13
- typo3/sysext/extbase/Tests/Functional/Persistence/OperatorTest.php+4 −12
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryLocalizedDataTest.php+6 −13
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryParserTest.php+10 −31
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+24 −51
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslatedSiteContentTest.php+2 −11
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php+2 −9
- typo3/sysext/extbase/Tests/Functional/Persistence/WorkspaceTest.php+2 −7
- typo3/sysext/extbase/composer.json+2 −1
- composer.json+1 −0
Review log 1732
Show 37 earlier messages
-
Alexander Schnitzler uploaded patch set 1 09/08/20, 14:28
-
TYPO3com voted on patch set 1 V -1 09/08/20, 14:40 Completed build in 11m 57s on Tue, 8 Sep, 02:40 PM Test Summary: 702 of 73658 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5372
-
Benni Mack uploaded patch set 2 03/22/21, 19:37
-
TYPO3com voted on patch set 2 V -1 03/22/21, 19:37 Completed build in 22s on Mon, 22 Mar, 07:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10298
-
core-ci voted on patch set 2 V -1 03/22/21, 19:38 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1772
-
Benni Mack rebased onto patch set 3 04/27/21, 21:51
-
core-ci voted on patch set 3 V -1 04/27/21, 21:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10803
-
Benni Mack uploaded patch set 4 04/27/21, 22:13
-
core-ci voted on patch set 4 V -1 04/27/21, 22:14 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10806
-
Benni Mack uploaded patch set 5 04/27/21, 22:22
-
core-ci voted on patch set 5 V -1 04/27/21, 22:39 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10807
-
Benni Mack uploaded patch set 6 04/27/21, 22:43
-
core-ci voted on patch set 6 V -1 04/27/21, 22:45 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10808
-
Benni Mack uploaded patch set 7 04/28/21, 07:58
-
core-ci voted on patch set 7 V -1 04/28/21, 08:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10822
-
Christian Kuhn rebased onto patch set 8 04/28/21, 11:16
-
core-ci voted on patch set 8 V -1 04/28/21, 11:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10830
-
Christian Kuhn uploaded patch set 9 04/28/21, 12:04
-
core-ci voted on patch set 9 V -1 04/28/21, 12:26 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10835
-
Christian Kuhn uploaded patch set 10 04/28/21, 14:46
-
core-ci voted on patch set 10 V -1 04/28/21, 14:48 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10839
-
Christian Kuhn uploaded patch set 11 04/28/21, 14:49
-
core-ci voted on patch set 11 V +1 04/28/21, 15:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10840
-
Christian Kuhn uploaded patch set 12 04/28/21, 17:10
-
core-ci voted on patch set 12 V -1 04/28/21, 17:12 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10842
-
Christian Kuhn uploaded patch set 13 04/28/21, 17:13
-
core-ci voted on patch set 13 V +1 04/28/21, 17:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10843
-
Christian Kuhn updated the commit message in patch set 14 04/28/21, 17:28
-
core-ci voted on patch set 14 V +1 04/28/21, 17:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10844
-
Benni Mack commented on patch set 14 V +1 CR +1 04/28/21, 18:05
This change is ready for review. -
Christian Kuhn voted on patch set 14 V +2 CR +2 04/28/21, 18:52
-
Christian Kuhn merged patch set 15 04/28/21, 18:52