Review main Merged

65639[TASK] Avoid objectManager->get() in functional tests

Alexander Schnitzler CR +2 V +2 Hard +238 −447 updated 04/28/21, 18:52

Commit message

To further phase out extbase ObjectManager, the
functional tests now use container->get() to set
up tests.
Some fixture files are moved to over to full
test extensions to supply a Services.yaml file.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 40

Show 20 more files

Review log 1732

Show 37 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 09/08/20, 14:28

  2. TYPO3com voted on patch set 1 V -1 09/08/20, 14:40 Completed build in 11m 57s on Tue, 8 Sep, 02:40 PM Test Summary: 702 of 73658 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5372

  3. Benni Mack uploaded patch set 2 03/22/21, 19:37

  4. TYPO3com voted on patch set 2 V -1 03/22/21, 19:37 Completed build in 22s on Mon, 22 Mar, 07:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10298

  5. core-ci voted on patch set 2 V -1 03/22/21, 19:38 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1772

  6. Benni Mack rebased onto patch set 3 04/27/21, 21:51

  7. core-ci voted on patch set 3 V -1 04/27/21, 21:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10803

  1. Benni Mack uploaded patch set 4 04/27/21, 22:13

  2. core-ci voted on patch set 4 V -1 04/27/21, 22:14 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10806

  3. Benni Mack uploaded patch set 5 04/27/21, 22:22

  4. core-ci voted on patch set 5 V -1 04/27/21, 22:39 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10807

  5. Benni Mack uploaded patch set 6 04/27/21, 22:43

  6. core-ci voted on patch set 6 V -1 04/27/21, 22:45 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10808

  7. Benni Mack uploaded patch set 7 04/28/21, 07:58

  8. core-ci voted on patch set 7 V -1 04/28/21, 08:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10822

  9. Christian Kuhn rebased onto patch set 8 04/28/21, 11:16

  10. core-ci voted on patch set 8 V -1 04/28/21, 11:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10830

  11. Christian Kuhn uploaded patch set 9 04/28/21, 12:04

  12. core-ci voted on patch set 9 V -1 04/28/21, 12:26 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10835

  13. Christian Kuhn uploaded patch set 10 04/28/21, 14:46

  14. core-ci voted on patch set 10 V -1 04/28/21, 14:48 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10839

  15. Christian Kuhn uploaded patch set 11 04/28/21, 14:49

  16. core-ci voted on patch set 11 V +1 04/28/21, 15:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10840

  17. Christian Kuhn uploaded patch set 12 04/28/21, 17:10

  18. core-ci voted on patch set 12 V -1 04/28/21, 17:12 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10842

  19. Christian Kuhn uploaded patch set 13 04/28/21, 17:13

  20. core-ci voted on patch set 13 V +1 04/28/21, 17:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10843

  21. Christian Kuhn updated the commit message in patch set 14 04/28/21, 17:28

  22. core-ci voted on patch set 14 V +1 04/28/21, 17:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10844

  23. Benni Mack commented on patch set 14 V +1 CR +1 04/28/21, 18:05

    This change is ready for review.
  24. Christian Kuhn voted on patch set 14 V +2 CR +2 04/28/21, 18:52

  25. Christian Kuhn merged patch set 15 04/28/21, 18:52