Review main Merged

6564[FEATURE][API] Add PostProcessing Hook after inclusion of extTables

Steffen Ritter CR +2 V +2 Normal +98 −1 updated 06/03/13, 20:49

Commit message

For modifiying the TCA of all Tables, you need to have an entry point
somewhere, shortly after all TCA definitions (which sould be within
ext_tables.php of each extension) are included.

To solve this problem a hook is introduced which allows to e.g. modify
all TCA tables in comparison to the classic way, where extensions are
only featured to modify TCA of extensions which had been loaded before.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Dominik Mathern +1
    • Oliver Hader +1
  • Verified V +2
    • Steffen Ritter +2
    • Dominik Mathern +1
    • Oliver Hader +1

Issues 1

Files 6

Review log 23

  1. Oliver Hader commented on patch set 2 12/18/11, 10:11

    (3 inline comments)
  2. Georg Ringer commented on patch set 2 12/18/11, 10:11

    I would prefer that you didn't submit this please fix at least the typos

    core_autoload.php:237

    please add a , at the end

    interface.t3lib_exttables_postprocessinghook.php:30

    i guess which = with

    interface.t3lib_exttables_postprocessinghook.php:32

    space instead of tab

    interface.t3lib_exttables_postprocessinghook.php:40

    off = of Extensions = extensions

    init.php:328

    this is not part of that patch!

    class.tx_install.php:7500

    some tabs too much?
  3. Steffen Ritter uploaded patch set 2 12/18/11, 10:11

    init.php:328 Reply

    that's why it is neither green or red or marked with + / - ? so what is your point?

    init.php:388 Reply

    ask doc_core_api :) it's just a copy paste from there....
  4. Dmitry Dulepov commented on patch set 3 12/18/11, 10:11

    (1 inline comment) Fine with me.
  5. Stefan Neufeind commented on patch set 3 12/18/11, 10:11

    (2 inline comments) small typo with "sould" -> "should" in the comit-msg. Other than that it looks okay. But Helmut's comment about the caching makes me wonder ...
  6. Oliver Hader uploaded patch set 4 12/18/11, 10:11

  7. Oliver Hader commented on patch set 4 12/18/11, 10:11

    Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:0, R:1 from Georg Ringer <mail@ringerge.org> V:1, R:0 from Thomas Maroschik <tmaroschik@dfau.de>
  8. Helmut Hummel commented on patch set 3 12/18/11, 10:11

    (1 inline comment) I don't understand the usecase for this hook. If extension A needs to modify TCA of extension B, then extension A depends on extension B, so B will always be loaded before A
  9. Georg Ringer commented on patch set 3 12/18/11, 10:11

    (1 inline comment)
  10. Georg Ringer commented on patch set 3 1 comment 12/18/11, 10:11

    Looks good to me, but someone else must approve
  11. Steffen Ritter commented on patch set 3 12/18/11, 10:11

    And if an extension needs to adapt every extensions? And if the extension itself is a sys_extension, or an extension many others rely on? THis is basically needed for the semantic stuff. Tools like identity or taxonomy want to add "additional fields" like category, uuid to every table. But other extensions, will have them in their required fields... And it would be hard to keep track of having them always loaded last...
  12. Steffen Ritter commented on patch set 3 12/18/11, 10:11

    (1 inline comment)
  13. Steffen Ritter commented on patch set 3 12/18/11, 10:11

    (1 inline comment) Hi Georg, just responded to your comment...
  14. Steffen Ritter uploaded patch set 3 12/18/11, 10:11

  15. Steffen Ritter commented on patch set 4 V 0 12/18/11, 10:11

    by team member; Looks good to me, approved
  16. Thomas Maroschik commented on patch set 3 12/18/11, 10:11

    Looks good to me, but someone else must approve
  17. Thomas Maroschik commented on patch set 3 12/18/11, 10:11

    Verified; No score Works on current master. Cherry picked with "git fetch git://git.typo3.org/TYPO3v4/Core refs/changes/64/6564/3 && git cherry-pick --strategy=resolve FETCH_HEAD"
  18. Mr. Jenkins commented on patch set 1 12/18/11, 10:11

  19. Mr. Jenkins commented on patch set 2 12/18/11, 10:11

  20. Mr. Jenkins commented on patch set 3 12/18/11, 10:11

  21. Mr. Jenkins commented on patch set 4 12/18/11, 10:11

  22. Dominik Mathern commented on patch set 4 12/18/11, 10:11

    Verified; Looks good to me, but someone else must approve
  23. Steffen Ritter merged patch set 4 12/18/11, 10:11