6564[FEATURE][API] Add PostProcessing Hook after inclusion of extTables
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Dominik Mathern +1
- Oliver Hader +1
-
Verified V +2
- Steffen Ritter +2
- Dominik Mathern +1
- Oliver Hader +1
Issues 1
Files 6
- t3lib/interfaces/interface.t3lib_exttables_postprocessinghook.php3new+48 −0
- t3lib/core_autoload.php2+2 −1
- typo3/sysext/cms/tslib/class.tslib_fe.php3+11 −0
- typo3/sysext/install/mod/class.tx_install.php2+13 −0
- typo3/sysext/install/updates/class.tx_coreupdates_migrateworkspaces.php1+12 −0
- typo3/init.php5+12 −0
Review log 23
-
Oliver Hader commented on patch set 2 12/18/11, 10:11
(3 inline comments) -
Georg Ringer commented on patch set 2 12/18/11, 10:11
I would prefer that you didn't submit this please fix at least the typoscore_autoload.php:237please add a , at the endinterface.t3lib_exttables_postprocessinghook.php:30i guess which = withinterface.t3lib_exttables_postprocessinghook.php:32space instead of tabinterface.t3lib_exttables_postprocessinghook.php:40off = of Extensions = extensionsinit.php:328this is not part of that patch!class.tx_install.php:7500some tabs too much? -
Steffen Ritter uploaded patch set 2 12/18/11, 10:11
init.php:328Replythat's why it is neither green or red or marked with + / - ? so what is your point?init.php:388Replyask doc_core_api :) it's just a copy paste from there.... -
Dmitry Dulepov commented on patch set 3 12/18/11, 10:11
(1 inline comment) Fine with me. -
Stefan Neufeind commented on patch set 3 12/18/11, 10:11
(2 inline comments) small typo with "sould" -> "should" in the comit-msg. Other than that it looks okay. But Helmut's comment about the caching makes me wonder ... -
Oliver Hader uploaded patch set 4 12/18/11, 10:11
-
Oliver Hader commented on patch set 4 12/18/11, 10:11
Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:0, R:1 from Georg Ringer <mail@ringerge.org> V:1, R:0 from Thomas Maroschik <tmaroschik@dfau.de> -
Helmut Hummel commented on patch set 3 12/18/11, 10:11
(1 inline comment) I don't understand the usecase for this hook. If extension A needs to modify TCA of extension B, then extension A depends on extension B, so B will always be loaded before A -
Georg Ringer commented on patch set 3 12/18/11, 10:11
(1 inline comment) -
Georg Ringer commented on patch set 3 1 comment 12/18/11, 10:11
Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 3 12/18/11, 10:11
And if an extension needs to adapt every extensions? And if the extension itself is a sys_extension, or an extension many others rely on? THis is basically needed for the semantic stuff. Tools like identity or taxonomy want to add "additional fields" like category, uuid to every table. But other extensions, will have them in their required fields... And it would be hard to keep track of having them always loaded last... -
Steffen Ritter commented on patch set 3 12/18/11, 10:11
(1 inline comment) -
Steffen Ritter commented on patch set 3 12/18/11, 10:11
(1 inline comment) Hi Georg, just responded to your comment... -
Steffen Ritter uploaded patch set 3 12/18/11, 10:11
-
Steffen Ritter commented on patch set 4 V 0 12/18/11, 10:11
by team member; Looks good to me, approved -
Thomas Maroschik commented on patch set 3 12/18/11, 10:11
Looks good to me, but someone else must approve -
Thomas Maroschik commented on patch set 3 12/18/11, 10:11
Verified; No score Works on current master. Cherry picked with "git fetch git://git.typo3.org/TYPO3v4/Core refs/changes/64/6564/3 && git cherry-pick --strategy=resolve FETCH_HEAD" -
Mr. Jenkins commented on patch set 1 12/18/11, 10:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2368/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/18/11, 10:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2369/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/18/11, 10:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2471/ : SUCCESS -
Mr. Jenkins commented on patch set 4 12/18/11, 10:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2636/ : SUCCESS -
Dominik Mathern commented on patch set 4 12/18/11, 10:11
Verified; Looks good to me, but someone else must approve -
Steffen Ritter merged patch set 4 12/18/11, 10:11