65640[TASK] Make Argument and Arguments classes dependency free
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php7+47 −2
- typo3/sysext/extbase/Classes/Mvc/Controller/Argument.php2+12 −42
- typo3/sysext/extbase/Classes/Mvc/Controller/Arguments.php+2 −15
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentsTest.php+5 −33
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentTest.php+0 −72
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php+0 −4
Review log 2229
Show 24 earlier messages
-
Alexander Schnitzler uploaded patch set 1 09/08/20, 15:49
-
TYPO3com voted on patch set 1 V -1 09/08/20, 16:01 Completed build in 11m 49s on Tue, 8 Sep, 04:01 PM Test Summary: 174 of 73658 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5373
-
Alexander Schnitzler uploaded patch set 2 09/08/20, 16:17
-
TYPO3com voted on patch set 2 V +1 09/08/20, 16:29 Completed build in 11m 41s on Tue, 8 Sep, 04:28 PM Test Summary: 73149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5374
-
Alexander Schnitzler wrote 09/08/20, 18:16
Topic set to extbase -
Alexander Schnitzler commented on patch set 2 CR -1 09/08/20, 18:38
Argument.php:112Unresolveduse makeInstance here to enable xclassingArgument.php:313Unresolvedremove this -
Alexander Schnitzler updated the commit message in patch set 3 09/09/20, 09:01
-
Alexander Schnitzler uploaded patch set 4 09/09/20, 09:13
-
TYPO3com voted on patch set 3 V +1 09/09/20, 09:17 Completed build in 14m 35s on Wed, 9 Sep, 09:17 AM Test Summary: 73149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5392
-
TYPO3com voted on patch set 4 V +1 09/09/20, 09:25 Completed build in 11m 51s on Wed, 9 Sep, 09:25 AM Test Summary: 73149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5393
-
Alexander Schnitzler commented on patch set 4 09/23/20, 11:00
ping -
Oliver Klee updated the commit message in patch set 5 09/23/20, 13:23
-
Oliver Klee commented on patch set 5 09/23/20, 13:25
ActionController.php:963Should we add @param mixed $rawValue to make it explicit that any type is allowed? -
TYPO3com voted on patch set 5 V +1 09/23/20, 13:35 Completed build in 12m 00s on Wed, 23 Sep, 01:35 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5860
-
Benni Mack commented on patch set 5 CR +1 09/28/20, 08:10
nice one. testing will follow -
Alexander Schnitzler commented on patch set 5 10/06/20, 10:59
ActionController.php:963ReplyContrary to "any type is allowed", what is your expectation if there is no type hint at all? Or what additional information does that annotation bring? Asking out of curiosity as I interpret variables without type hints as mixed anyway. -
Oliver Klee commented on patch set 5 10/06/20, 12:36
ActionController.php:963ReplyThe difference is for the reader: If the type is annotated as "mixed", I know that I can pass any type, and that the code explicitly communicates this. If there is no annotation, this reads as "we do not provide any information about the restrictions", i.e., I don't know whether I can pass any type or whether there are any (undocumented) restrictions like int|string|null or something. Also, as a reader, I cannot differentiate between "any type is okay, and this is by design" and "we have forgotten the annotation". -
Alexander Schnitzler commented on patch set 5 10/07/20, 10:44
ActionController.php:963ReplyOk, fine. Will add the type hint. -
Alexander Schnitzler uploaded patch set 6 10/07/20, 10:46
-
Alexander Schnitzler commented on patch set 6 10/07/20, 10:47
ActionController.php:963Replytype hint added although this is a private method and user shouldn't even care about what to put into here. ;) -
Oliver Klee commented on patch set 6 10/07/20, 10:49
Thanks! <3 -
TYPO3com voted on patch set 6 V +1 10/07/20, 11:09 Completed build in 14m 02s on Wed, 7 Oct, 11:09 AM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6318
-
Stefan Froemken commented on patch set 6 CR -1 10/07/20, 18:06
ActionController.php:970Why do you not allow overwriting the value with null anymore? -
Alexander Schnitzler uploaded patch set 7 10/08/20, 09:50
-
Alexander Schnitzler commented on patch set 7 10/08/20, 09:50
ActionController.php:970ReplyGood catch! -
TYPO3com voted on patch set 7 V +1 10/08/20, 10:01 Completed build in 11m 39s on Thu, 8 Oct, 10:01 AM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6355
-
Benni Mack voted on patch set 7 V +1 CR +1 10/08/20, 10:27
-
Daniel Goerz voted on patch set 7 V +2 CR +2 10/08/20, 10:58
-
Daniel Goerz merged patch set 8 10/08/20, 10:58