Review 9.5 Merged

65641[BUGFIX] Ensure cache entries in PageRepository consider groups

Anja Leichsenring CR -1 V +2 Easy +9 −1 updated 09/22/20, 08:55

Commit message

The results of the hook in PageRepository->enableFields and of
PageRepository->getMultipleGroupsWhereClause may be different,
depending on the Context state for usergroups.
In TYPO3 v9, PageRepository was also used when resolving pages
during Routing (where there is no user / group resolved yet),
which is why we may face different states of usergroups in PageRepository.

Review

  • Code review CR -1 Done
    • Benni Mack +2
    • Anja Leichsenring -1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Praetorius +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Anja Leichsenring uploaded patch set 1 09/08/20, 18:50

  2. Anja Leichsenring commented on patch set 1 CR -1 09/08/20, 18:51

    @Benni the backport conflicted, did I do it right?
  3. TYPO3com voted on patch set 1 V +1 09/08/20, 19:07 Completed build in 14m 52s on Tue, 8 Sep, 07:07 PM Test Summary: 75179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-795

  4. Simon Praetorius commented on patch set 1 V +1 CR +1 09/22/20, 08:50

    Tested it in our project that triggered the bug report. Works just fine!
  5. Benni Mack voted on patch set 1 V +2 CR +2 09/22/20, 08:55

  6. Benni Mack merged patch set 2 09/22/20, 08:55