Review main Merged

65643[TASK] DatabaseRecordList: Streamline pagination

Daniel Windloff CR +2 V +2 Normal +112 −133 updated 03/31/21, 14:08

Commit message

* The pointer to the first record has been replaced
  by the current page for the pagination.
* The calculation of the first element has been moved
  to the 'getTable()' method.
* The inline javascript has been moved to PageBrowser.js.
* The rendering of the paging element has been moved to
  a fluid template.
* The refresh button now reloads the page and does not
  change the current page any more.
* The wrapping 'tr' and 'td' are also moved to the
  fluid template.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 7

Review log 3561

Show 2136 earlier messages
  1. Daniel Windloff uploaded patch set 1 09/09/20, 07:10

  2. TYPO3com voted on patch set 1 V +1 09/09/20, 07:21 Completed build in 10m 50s on Wed, 9 Sep, 07:21 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5381

  3. Andreas Kienast commented on patch set 1 CR -1 09/09/20, 07:26

    PageBrowser.ts:24

    You may drop that check. querySelectorAll will never return null, but an empty collection instead which will be skipped by .forEach().

    DatabaseRecordList.php:998

    Under which circumstance is $fieldArray no (empty) array?
  4. Daniel Windloff uploaded patch set 2 09/09/20, 07:32

  5. Daniel Windloff commented on patch set 2 09/09/20, 07:35

    PageBrowser.ts:24 Reply

    Done

    DatabaseRecordList.php:998 Reply

    Never, just a habit ;).
  6. TYPO3com voted on patch set 2 V +1 09/09/20, 07:43 Completed build in 11m 27s on Wed, 9 Sep, 07:43 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5384

  7. Björn Jacob commented on patch set 2 09/09/20, 08:44

    Just out of curiosity: why don't you use the native pagination which made it into the core in 10.2? https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/10.2/Feature-89603-IntroduceNativePaginationForLists.html
  8. Daniel Windloff commented on patch set 2 09/09/20, 10:28

    > Patch Set 2: > > Just out of curiosity: why don't you use the native pagination which made it into the core in 10.2? https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/10.2/Feature-89603-IntroduceNativePaginationForLists.html I'm aware of that api and it would be the better solution. The concrete reason for not using the api at the moment is, that the list module does not have a fixed number of elements in the query for a page, only a fixed number of elements, which are displayed on a page. The architectural reason is the coupling between the sorting (TCAs sorting column) and the query. For pages > 1 more records are fetched to take the last records of the previous page into account for backsorting.
  9. Daniel Windloff uploaded patch set 3 09/19/20, 04:55

  10. TYPO3com voted on patch set 3 V +1 09/19/20, 05:06 Completed build in 11m 08s on Sat, 19 Sep, 05:06 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5734

  11. Björn Jacob updated the commit message in patch set 4 09/19/20, 07:50

  12. Björn Jacob commented on patch set 4 CR +1 09/19/20, 07:50

    Thx for your explanation. Good stuff.
  13. TYPO3com voted on patch set 4 V -1 09/19/20, 08:04 Completed build in 13m 56s on Sat, 19 Sep, 08:04 AM Test Summary: 1 of 74144 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5738

  14. TYPO3com voted on patch set 4 V +1 09/19/20, 17:48 Completed build in 14m 21s on Sat, 19 Sep, 05:48 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5748

  15. Andreas Kienast commented on patch set 4 V -1 09/20/20, 10:55

    When in single table view, I have two pages but I'm able to load page 4 of 2, which renders an empty table then.
  16. Daniel Windloff uploaded patch set 5 09/20/20, 12:38

  17. TYPO3com voted on patch set 5 V +1 09/20/20, 12:50 Completed build in 12m 02s on Sun, 20 Sep, 12:50 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5761

  18. Daniel Windloff commented on patch set 5 09/20/20, 12:57

    > Patch Set 4: Verified-1 > > When in single table view, I have two pages but I'm able to load page 4 of 2, which renders an empty table then. Added min max evaluation based on input's attrs
  19. Daniel Windloff uploaded patch set 6 09/27/20, 14:54

  20. TYPO3com voted on patch set 6 V +1 09/27/20, 15:17 Completed build in 14m 49s on Sun, 27 Sep, 03:17 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6029

  21. Daniel Windloff commented on patch set 6 09/27/20, 15:51

    Resolved merge conflict.
  22. Martin Kutschker commented on patch set 6 01/31/21, 16:43

    ListNavigation.html:4 Unresolved

    A region without an accessible name is pointless. Please, either add one (in this case I suggest aria-labale) or remove it (use a div if you need the container).

    ListNavigation.html:9 Unresolved

    Don't use plain title attributes for tooltips. Please, either remove the attribute or use a Boostrap tooltip. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/66237/ Sidenote: 66237 uses BS tooltips automatically for all links in the list module (JS init code)
  23. Benni Mack uploaded patch set 7 03/24/21, 14:38

  24. Markus Klein commented on patch set 7 03/24/21, 14:45

    PageBrowser.ts:23 Unresolved

    We have not DOMready event check here. so this will cause timing issues
  25. TYPO3com voted on patch set 7 V -1 03/24/21, 14:45 Completed build in 06m 31s on Wed, 24 Mar, 02:45 PM Test Summary: 32798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10326

  26. core-ci voted on patch set 7 V -1 03/24/21, 14:55 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1806

  27. Benni Mack uploaded patch set 8 03/26/21, 16:44

  28. Benni Mack uploaded patch set 9 03/26/21, 16:51

  29. TYPO3com voted on patch set 8 V +1 03/26/21, 16:51 Completed build in 06m 50s on Fri, 26 Mar, 04:51 PM Test Summary: 33257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10369

  30. core-ci voted on patch set 8 V -1 03/26/21, 16:56 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1865

  31. TYPO3com voted on patch set 9 V -1 03/26/21, 17:00 Completed build in 07m 56s on Fri, 26 Mar, 05:00 PM Test Summary: 32849 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10371

  32. core-ci voted on patch set 9 V -1 03/26/21, 17:08 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1868

  33. Martin Kutschker commented on patch set 9 CR -1 03/27/21, 13:29

    ListNavigation.html:4 Unresolved

    A landmark like nav needs an accessible name. Please add one with aria-label that makes the purpose clear. Don't use the word "navigation" as it is announced by a screen reader.

    ListNavigation.html:13 Unresolved

    The item's link has no link text. This is sadly true for many icon buttons in the core, but we should try to add new markup with this problems. Possible solutions: custom HTML element, Fluid partial or view helper. If the list item is disabled it has no content (see above), but will be counted in the total number of list items. Either provide a non-liked text or remove the the item from the accessible tree.

    ListNavigation.html:20 Unresolved

    The field has no label.

    ListNavigation.html:22 Unresolved

    The text "page n of m" is not conveyed for a screen reader. It is not clear on which page he user is now and how many are present at the moment he enters the field.
  34. Benni Mack uploaded patch set 10 03/28/21, 20:15

  35. TYPO3com voted on patch set 10 V -1 03/28/21, 20:23 Completed build in 07m 52s on Sun, 28 Mar, 08:23 PM Test Summary: 33263 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10379

  36. core-ci voted on patch set 10 V -1 03/28/21, 20:25 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1883

  1. Benni Mack uploaded patch set 11 03/28/21, 20:51

  2. TYPO3com voted on patch set 11 V +1 03/28/21, 20:58 Completed build in 06m 39s on Sun, 28 Mar, 08:58 PM Test Summary: 33263 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10380

  3. core-ci voted on patch set 11 V +1 03/28/21, 21:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1884

  4. Christian Kuhn uploaded patch set 12 03/30/21, 12:45

  5. Christian Kuhn commented on patch set 12 CR -1 03/30/21, 12:45

    on it.
  6. TYPO3com voted on patch set 12 V +1 03/30/21, 12:53 Completed build in 07m 37s on Tue, 30 Mar, 12:53 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10394

  7. core-ci voted on patch set 12 V -1 03/30/21, 12:56 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1914

  8. Christian Kuhn voted on patch set 12 V +1 CR +1 03/30/21, 12:59

  9. core-ci voted on patch set 12 V +1 03/30/21, 13:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1914

  10. Richard Haeser voted on patch set 12 V +2 CR +2 03/30/21, 13:57

  11. Richard Haeser commented on patch set 12 V +1 CR 0 03/30/21, 14:02

    Reverted into +1 verified after seeing the comments of Martin.
  12. Richard Haeser commented on patch set 12 CR -1 03/30/21, 14:04

    Martin will have a look at the accessibility issues
  13. Martin Kutschker commented on patch set 12 03/30/21, 19:25

    ListNavigation.html:4 Unresolved

    Class pagination-block is not defined.

    ListNavigation.html:15 Unresolved

    Class .disabled is only defined together with class .btn.

    ListNavigation.html:21 Unresolved

    Without explicit autocomplete attribute the field will be announced with having auto fill-in active. As it makes no sense here it should be turned off.
  14. Martin Kutschker uploaded patch set 13 03/30/21, 19:26

  15. TYPO3com voted on patch set 13 V -1 03/30/21, 19:33 Completed build in 07m 07s on Tue, 30 Mar, 07:33 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10396

  16. core-ci voted on patch set 13 V -1 03/30/21, 19:37 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1916

  17. Martin Kutschker uploaded patch set 14 03/30/21, 19:41

  18. TYPO3com voted on patch set 14 V +1 03/30/21, 19:48 Completed build in 06m 32s on Tue, 30 Mar, 07:48 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10397

  19. core-ci voted on patch set 14 V +1 03/30/21, 19:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1917

  20. Christian Kuhn uploaded patch set 15 03/31/21, 13:37

  21. Christian Kuhn voted on patch set 15 V +1 CR +1 03/31/21, 13:40

  22. TYPO3com voted on patch set 15 V +1 03/31/21, 13:44 Completed build in 07m 36s on Wed, 31 Mar, 01:44 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10409

  23. core-ci voted on patch set 15 V +1 03/31/21, 13:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1934

  24. Benni Mack voted on patch set 15 V +2 CR +2 03/31/21, 14:08

  25. Benni Mack merged patch set 16 03/31/21, 14:08