Review main Merged

65645[BUGFIX] Do not stop rewrite processing for favicon.ico

Christian Futterlieb CR +2 V +2 Easy +1 −1 updated 09/20/20, 07:44

Commit message

Requests to /favicon.ico should not stop rewrite processing. They could
trigger a static route or could be handeled by an error handler.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Frank Nägler +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Christian Futterlieb uploaded patch set 1 09/09/20, 09:17

  2. Mathias Brodala commented on patch set 1 CR -1 09/09/20, 09:23

    The "/favicon.ico" location is a de-facto standard and many projects will provide the file exactly at this location. Having this handled by TYPO3 will break delivery of static files at this location. So if at all this change should be marked as breaking.
  3. TYPO3com voted on patch set 1 V +1 09/09/20, 09:30 Completed build in 13m 00s on Wed, 9 Sep, 09:30 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5394

  4. Christian Futterlieb commented on patch set 1 09/09/20, 09:33

    > Having this handled by TYPO3 will break delivery of static files at this location. That's wrong: TYPO3 won't be invoked because of the rule that follows later onn: RewriteCond %{REQUEST_FILENAME} !-f If this file is present, it can be accessed anyway. This change should only point to installationns, where no such file exists
  5. Mathias Brodala commented on patch set 1 CR +1 09/09/20, 09:34

    > Patch Set 1: > > > Having this handled by TYPO3 will break delivery of static files at this location. > > That's wrong: TYPO3 won't be invoked because of the rule that follows later onn: > > RewriteCond %{REQUEST_FILENAME} !-f > > If this file is present, it can be accessed anyway. This change should only point to installationns, where no such file exists Indeed, that's true, I forgot about this. :-)
  6. Frank Nägler voted on patch set 1 V +1 CR +1 09/11/20, 14:40

  7. Daniel Goerz voted on patch set 1 CR +2 09/20/20, 07:44

  8. Daniel Goerz voted on patch set 1 V +2 09/20/20, 07:44

  9. Daniel Goerz merged patch set 2 09/20/20, 07:44