65646[TASK] Avoid usage of object manager in validation related classes
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/extbase/Classes/Validation/Validator/CollectionValidator.php+6 −6
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+2 −16
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php+0 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/CollectionValidatorTest.php+3 −0
Review log 1215
-
Alexander Schnitzler uploaded patch set 1 09/09/20, 09:25
-
Alexander Schnitzler wrote 09/09/20, 09:25
Topic set to extbase -
Alexander Schnitzler uploaded patch set 2 09/09/20, 09:36
-
TYPO3com voted on patch set 1 V -1 09/09/20, 09:36 Completed build in 11m 44s on Wed, 9 Sep, 09:36 AM Test Summary: 39 of 73658 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5395
-
TYPO3com voted on patch set 2 V +1 09/09/20, 09:47 Completed build in 11m 22s on Wed, 9 Sep, 09:47 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5396
-
Alexander Schnitzler updated the commit message in patch set 3 09/09/20, 09:55
-
TYPO3com voted on patch set 3 V +1 09/09/20, 10:06 Completed build in 11m 06s on Wed, 9 Sep, 10:06 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5398
-
Alexander Schnitzler commented on patch set 3 09/22/20, 12:18
ping -
Oliver Klee voted on patch set 3 CR +1 09/22/20, 12:26
-
Oliver Klee commented on patch set 3 09/22/20, 12:26
Is 10.4 affected as well? -
Georg Ringer voted on patch set 3 V +1 CR +1 09/22/20, 14:34
-
Oli Bartsch voted on patch set 3 CR +1 09/22/20, 15:53
-
Benni Mack voted on patch set 3 V +2 CR +2 09/22/20, 15:55
-
Benni Mack merged patch set 4 09/22/20, 15:55
-
Alexander Schnitzler commented on patch set 4 09/22/20, 18:39
Reply Unresolved
No, those patches are for master only since we want to remove the object manager and can't do that anymore in older versions.