Review main Merged

65646[TASK] Avoid usage of object manager in validation related classes

Alexander Schnitzler CR +2 V +2 Easy +11 −24 updated 09/22/20, 18:39

Commit message

Since validators have an internal state (prototypes) they must not
have services injected. Also, the ValidatorResolver must not use
the object manager directly to create validator instances.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1215

  1. Alexander Schnitzler uploaded patch set 1 09/09/20, 09:25

  2. Alexander Schnitzler wrote 09/09/20, 09:25

    Topic set to extbase
  3. Alexander Schnitzler uploaded patch set 2 09/09/20, 09:36

  4. TYPO3com voted on patch set 1 V -1 09/09/20, 09:36 Completed build in 11m 44s on Wed, 9 Sep, 09:36 AM Test Summary: 39 of 73658 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5395

  5. TYPO3com voted on patch set 2 V +1 09/09/20, 09:47 Completed build in 11m 22s on Wed, 9 Sep, 09:47 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5396

  6. Alexander Schnitzler updated the commit message in patch set 3 09/09/20, 09:55

  7. TYPO3com voted on patch set 3 V +1 09/09/20, 10:06 Completed build in 11m 06s on Wed, 9 Sep, 10:06 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5398

  8. Alexander Schnitzler commented on patch set 3 09/22/20, 12:18

    ping
  9. Oliver Klee voted on patch set 3 CR +1 09/22/20, 12:26

  10. Oliver Klee commented on patch set 3 09/22/20, 12:26

    Is 10.4 affected as well?
  11. Georg Ringer voted on patch set 3 V +1 CR +1 09/22/20, 14:34

  12. Oli Bartsch voted on patch set 3 CR +1 09/22/20, 15:53

  13. Benni Mack voted on patch set 3 V +2 CR +2 09/22/20, 15:55

  14. Benni Mack merged patch set 4 09/22/20, 15:55

  15. Alexander Schnitzler commented on patch set 4 09/22/20, 18:39

    Reply Unresolved

    No, those patches are for master only since we want to remove the object manager and can't do that anymore in older versions.