Review main Merged

65648[BUGFIX] Revert "[BUGFIX] Add support for symfony/event-dispatcher-contracts v1"

Benjamin Franzke CR +2 V +2 Easy +3 −3 updated 09/09/20, 10:53

Commit message

This reverts commit e2b1148cef57d434ddda035da3d693f784a1e0f1.

Our Event dispatcher adapter is currently not compatible with
symfony/event-dispatcher-contracts:v1 (type declaration mismatch)
and therefore results in a runtime fatal error with symfony v4.

Compatibility with symfony v4 will be added in a new
revision of the reverted patch.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 45

  1. Benjamin Franzke uploaded patch set 1 09/09/20, 10:20

  2. Benni Mack commented on patch set 1 V +2 CR +2 09/09/20, 10:31

    please merge once bamboo says it's OK.
  3. TYPO3com voted on patch set 1 V +1 09/09/20, 10:32 Completed build in 11m 49s on Wed, 9 Sep, 10:32 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5401

  4. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/09/20, 10:53

  5. Benjamin Franzke merged patch set 2 09/09/20, 10:53