Review 10.4 Merged

65649[TASK] Drop workspace publish locking

Christian Kuhn CR +2 V +2 Easy +0 −22 updated 09/10/20, 09:39

Commit message

The workspace 'publish' process is encapsulated in a lock
file to prevent dupblicate publish of the same record at
the same time.

This is bogus:
* Other operations like modify or discard are not covered
* A stalled lock file can only happen if a process crashes
* Nothing else in the DataHandler has similar locking strategies
* The only way to recover from a stalled lock file is "ask your admin",
  which is not helpful in any way.

If the DataHandler (and with that the workspace operations) should
have locking, it needs to be implemented in the DataHandler at a
central place and not within a fraction of the workspace sub set.

The patch drops the publish process locking.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 09/09/20, 10:29

  2. TYPO3com voted on patch set 1 V +1 09/09/20, 10:41 Completed build in 11m 56s on Wed, 9 Sep, 10:41 AM Test Summary: 74190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-375

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 09/09/20, 11:51

  4. Benni Mack voted on patch set 1 V +2 CR +2 09/10/20, 09:39

  5. Benni Mack merged patch set 2 09/10/20, 09:39