65650[TASK] Do not use object manager in RequestHandlerResolver
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Oliver Klee +1
- Torben Hansen +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1316
-
Alexander Schnitzler uploaded patch set 1 09/09/20, 10:47
-
Alexander Schnitzler wrote 09/09/20, 10:55
Topic set to extbase -
TYPO3com voted on patch set 1 V +1 09/09/20, 11:00 Completed build in 12m 19s on Wed, 9 Sep, 11:00 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5404
-
Oliver Klee voted on patch set 1 CR +1 09/09/20, 11:46
-
Benjamin Franzke commented on patch set 1 CR -1 09/09/20, 13:23
IMO Dispatchers/resolvers should prefer to use the PSR-11 container (and then fallback to makeInstance if that is needed for backwards compatibility). Note: Depending on/injecting the PSR-11 container in lazy loaders (like dispatchers, resolvers) is fine, as they are allowed to be service locators. Examples in master: Psr\Container\ContainerInterface->get() + GU:makeInstance(): https://github.com/TYPO3/TYPO3.CMS/blob/71cca94c29a0/typo3/sysext/core/Classes/Http/Dispatcher.php#L76 https://github.com/TYPO3/TYPO3.CMS/blob/71cca94c29a0/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php#L163-L166 ContainerInterface->get() only (no need for makeInstance): https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/core/Classes/Console/CommandRegistry.php#L110-L113 TL;DR In this case we would need Psr\Container\ContainerInterface->get + makeInstance -
Alexander Schnitzler uploaded patch set 2 09/22/20, 12:25
-
TYPO3com voted on patch set 2 V -1 09/22/20, 12:41 Completed build in 16m 46s on Tue, 22 Sep, 12:41 PM Test Summary: 73340 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5812
-
TYPO3com voted on patch set 2 V +1 09/22/20, 18:48 Completed build in 6h 40m 14s on Tue, 22 Sep, 06:48 PM Test Summary: 73682 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5812
-
Oliver Klee voted on patch set 2 CR +1 09/23/20, 09:17
-
Christian Kuhn voted on patch set 2 V +1 09/23/20, 19:00
-
Torben Hansen voted on patch set 2 CR +1 09/26/20, 07:41
-
Andreas Kienast voted on patch set 2 CR +1 09/26/20, 08:07
-
Andreas Kienast voted on patch set 2 V +1 09/26/20, 08:30
-
Oli Bartsch voted on patch set 2 V +1 CR +1 09/26/20, 08:41
-
Andreas Kienast voted on patch set 2 V +2 CR +2 09/26/20, 08:45
-
Andreas Kienast merged patch set 3 09/26/20, 08:45