Review main Merged

65651[TASK] Avoid usage of object manager in RequestBuilder

Alexander Schnitzler CR +2 V +2 Normal +52 −129 updated 09/23/20, 18:39

Commit message

Replace ObjectManager->get() with GeneralUtility::makeInstance()

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1114

  1. Alexander Schnitzler uploaded patch set 1 09/09/20, 11:43

  2. Alexander Schnitzler wrote 09/09/20, 11:43

    Topic set to extbase
  3. Oliver Klee voted on patch set 1 CR +1 09/09/20, 11:46

  4. TYPO3com voted on patch set 1 V -1 09/09/20, 11:57 Completed build in 13m 58s on Wed, 9 Sep, 11:57 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5408

  5. Alexander Schnitzler uploaded patch set 2 09/23/20, 07:22

  6. TYPO3com voted on patch set 2 V -1 09/23/20, 07:38 Completed build in 15m 25s on Wed, 23 Sep, 07:38 AM Test Summary: 48 of 74161 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5845

  7. Alexander Schnitzler uploaded patch set 3 09/23/20, 10:22

  8. TYPO3com voted on patch set 3 V +1 09/23/20, 10:33 Completed build in 10m 55s on Wed, 23 Sep, 10:33 AM Test Summary: 73670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5849

  9. Benni Mack voted on patch set 3 V +1 CR +1 09/23/20, 14:13

  10. Oliver Klee voted on patch set 3 CR +1 09/23/20, 17:26

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 09/23/20, 18:38

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 09/23/20, 18:39

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 09/23/20, 18:39

  14. Christian Kuhn merged patch set 4 09/23/20, 18:39