Review main Merged

65652[TASK] Avoid usage of object manager in QueryObjectModelFactory

Alexander Schnitzler CR +2 V +2 Easy +15 −28 updated 09/09/20, 18:30

Commit message

Replace ObjectManager->get() with GeneralUtility::makeInstance()

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Alexander Schnitzler uploaded patch set 1 09/09/20, 11:50

  2. TYPO3com voted on patch set 1 V +1 09/09/20, 12:03 Completed build in 12m 14s on Wed, 9 Sep, 12:03 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5409

  3. Oliver Klee voted on patch set 1 CR +1 09/09/20, 15:08

  4. Benni Mack voted on patch set 1 V +1 CR +1 09/09/20, 15:24

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 09/09/20, 18:28

  6. Benni Mack voted on patch set 1 V +2 CR +2 09/09/20, 18:30

  7. Benni Mack merged patch set 2 09/09/20, 18:30