Review main Merged

65654[BUGFIX] Omit exception using localized file metadata with RTE

Chris Müller CR +2 V +2 Easy +10 −9 updated 10/07/20, 07:46

Commit message

Translating extended sys_file_metadata with an RTE field throwed an
exception because the iso code of a language id > 0 cannot be determined.
A null value was returned which violates the method's return type. As
a solution, English is returned.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1417

  1. Chris Müller uploaded patch set 1 09/09/20, 16:34

  2. TYPO3com voted on patch set 1 V +1 09/09/20, 16:45 Completed build in 10m 51s on Wed, 9 Sep, 04:45 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5419

  3. Markus Klein commented on patch set 1 09/09/20, 17:01

    Is there maybe a way to initialize the data array properly, so that languages are included? If not, please at least put there comment, why and where this case can happen and the fallback to "en" is needed
  4. Georg Ringer voted on patch set 1 V +1 CR +1 10/05/20, 21:50

  5. Markus Klein commented on patch set 1 10/06/20, 06:18

    RichTextElement.php:184 Unresolved

    shouldn't this be 'en_US' like below, to be consistent?
  6. Markus Klein commented on patch set 2 10/06/20, 07:59

    Published edit on patch set 1.
  7. Markus Klein voted on patch set 2 V +1 CR +1 10/06/20, 07:59

  8. TYPO3com voted on patch set 2 V +1 10/06/20, 08:13 Completed build in 14m 23s on Tue, 6 Oct, 08:13 AM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6259

  9. Oliver Hader voted on patch set 2 V +2 CR +2 10/06/20, 14:26

  10. Oliver Hader voted on patch set 2 CR 0 10/06/20, 14:29

  11. Oliver Hader commented on patch set 2 10/06/20, 14:35

    RichTextElement.php:185 Unresolved

    Just looked into Locales::getLocales(), which does not contain `en_US`... not sure here...
  12. Oliver Hader uploaded patch set 3 10/06/20, 14:44

  13. Oliver Hader voted on patch set 3 V +1 CR +1 10/06/20, 15:07

  14. TYPO3com voted on patch set 3 V +1 10/06/20, 15:09 Completed build in 24m 58s on Tue, 6 Oct, 03:09 PM Test Summary: 73784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6284

  15. Markus Klein voted on patch set 3 V +1 CR +1 10/06/20, 21:01

  16. Daniel Goerz voted on patch set 3 V +2 CR +2 10/07/20, 07:46

  17. Daniel Goerz merged patch set 4 10/07/20, 07:46