Review main Merged

65656[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Core

Sascha Egerer CR +2 V +2 Easy +10 −10 updated 09/26/20, 11:28

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Markus Klösges +1
    • Oli Bartsch +1
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:15

  2. Sascha Egerer wrote 09/09/20, 17:24

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:24

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 17:32 Completed build in 16m 43s on Wed, 9 Sep, 05:32 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5421

  5. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:57

  6. TYPO3com voted on patch set 3 V +1 09/10/20, 17:41 Completed build in 34m 58s on Thu, 10 Sep, 05:41 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5495

  7. Oliver Klee voted on patch set 3 CR +1 09/10/20, 19:14

  8. Markus Klösges voted on patch set 3 CR +1 09/25/20, 13:34

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 09/26/20, 08:39

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 09/26/20, 09:15

  11. Daniel Goerz voted on patch set 3 V +2 CR +2 09/26/20, 11:28

  12. Daniel Goerz merged patch set 4 09/26/20, 11:28