Review main Merged

65657[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Page

Sascha Egerer CR +2 V +2 Easy +13 −8 updated 09/23/20, 20:54

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1215

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:15

  2. Sascha Egerer wrote 09/09/20, 17:24

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:24

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 17:35 Completed build in 20m 28s on Wed, 9 Sep, 05:35 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5422

  5. Oliver Klee voted on patch set 2 CR +1 09/09/20, 18:27

  6. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:52

  7. Jörg Bösche voted on patch set 3 V +1 CR +1 09/10/20, 08:54

  8. TYPO3com voted on patch set 3 V +1 09/12/20, 19:04 Completed build in 14m 19s on Sat, 12 Sep, 07:04 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5563

  9. Oliver Klee voted on patch set 3 CR +1 09/13/20, 11:19

  10. Daniel Goerz uploaded patch set 4 09/23/20, 14:46

  11. Daniel Goerz voted on patch set 4 V +1 CR +1 09/23/20, 14:46

  12. TYPO3com voted on patch set 4 V +1 09/23/20, 15:11 Completed build in 19m 32s on Wed, 23 Sep, 03:11 PM Test Summary: 73682 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5872

  13. Oliver Klee voted on patch set 4 CR +1 09/23/20, 17:27

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 09/23/20, 20:54

  15. Christian Kuhn merged patch set 5 09/23/20, 20:54