Review main Merged

65658[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core TypoScript

Sascha Egerer CR +2 V +2 Normal +70 −47 updated 10/01/20, 13:41

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1318

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:15

  2. Sascha Egerer wrote 09/09/20, 17:24

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:24

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 17:40 Completed build in 24m 44s on Wed, 9 Sep, 05:40 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5423

  5. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:54

  6. TYPO3com voted on patch set 3 V +1 09/10/20, 17:50 Completed build in 37m 39s on Thu, 10 Sep, 05:50 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5501

  7. Oliver Klee voted on patch set 3 CR +1 09/10/20, 19:14

  8. Benni Mack voted on patch set 3 CR +1 09/23/20, 16:39

  9. Daniel Goerz uploaded patch set 4 09/29/20, 17:34

  10. Daniel Goerz commented on patch set 4 CR -1 09/29/20, 17:43

    TemplateService.php:785 Unresolved

    This must not be an intExplode!
  11. Daniel Goerz uploaded patch set 5 09/29/20, 17:45

  12. Daniel Goerz voted on patch set 5 V +1 CR +1 09/29/20, 17:49

  13. TYPO3com voted on patch set 4 V -1 09/29/20, 17:52 Completed build in 17m 55s on Tue, 29 Sep, 05:52 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6071

  14. TYPO3com voted on patch set 5 V -1 09/29/20, 17:59 Completed build in 14m 19s on Tue, 29 Sep, 05:59 PM Test Summary: 73679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6073

  15. TYPO3com voted on patch set 5 V +1 09/29/20, 18:08 Completed build in 37m 24s on Tue, 29 Sep, 06:08 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6073

  16. Oliver Klee voted on patch set 5 CR +1 09/29/20, 19:02

  17. Benni Mack voted on patch set 5 V +2 CR +2 10/01/20, 13:41

  18. Benni Mack merged patch set 6 10/01/20, 13:41