Review main Merged

65659[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Composer

Sascha Egerer CR +2 V +2 Easy +3 −0 updated 09/11/20, 08:00

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Sascha Egerer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1316

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:15

  2. Sascha Egerer wrote 09/09/20, 17:25

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:25

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 17:44 Completed build in 28m 52s on Wed, 9 Sep, 05:44 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5424

  5. Oliver Klee voted on patch set 2 CR +1 09/09/20, 18:29

  6. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:51

  7. Jörg Bösche voted on patch set 3 CR +1 09/10/20, 08:52

  8. TYPO3com voted on patch set 3 V +1 09/10/20, 18:12 Completed build in 59m 35s on Thu, 10 Sep, 06:12 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5504

  9. Sascha Egerer uploaded patch set 4 09/10/20, 18:49

  10. Sascha Egerer voted on patch set 4 CR +1 09/10/20, 18:49

  11. TYPO3com voted on patch set 4 V +1 09/10/20, 19:06 Completed build in 14m 15s on Thu, 10 Sep, 07:06 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5513

  12. Oliver Klee voted on patch set 4 CR +1 09/10/20, 19:12

  13. Daniel Goerz voted on patch set 4 V +1 CR +1 09/11/20, 07:13

  14. Oli Bartsch voted on patch set 4 V +1 CR +1 09/11/20, 07:16

  15. Daniel Goerz voted on patch set 4 V +2 CR +2 09/11/20, 08:00

  16. Daniel Goerz merged patch set 5 09/11/20, 08:00