Review main Merged

65660[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Tree

Sascha Egerer CR +2 V +2 Easy +2 −2 updated 09/18/20, 21:04

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Oliver Klee +1
    • Sascha Egerer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Sascha Egerer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:15

  2. Sascha Egerer wrote 09/09/20, 17:25

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:25

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 17:48 Completed build in 32m 52s on Wed, 9 Sep, 05:48 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5425

  5. Oliver Klee voted on patch set 2 CR +1 09/09/20, 18:29

  6. Sascha Egerer commented on patch set 2 CR -1 09/10/20, 07:24

    DatabaseTreeDataProvider.php:266

    Instead of casting the value to int i would first check if it can be interpreted as string. The getId method returns a string which could be something like `foo` which is then casted to `0` or `5foo` which is casted to `5`
  7. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:47

  8. TYPO3com voted on patch set 3 V +1 09/10/20, 09:32 Completed build in 32m 35s on Thu, 10 Sep, 09:32 AM Test Summary: 73171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5473

  9. Daniel Goerz commented on patch set 3 09/18/20, 09:44

    DatabaseTreeDataProvider.php:266 Reply Unresolved

    I think that's a little bit "over the top"as we are dealing with uids here.
  10. Daniel Goerz voted on patch set 3 V +1 CR +1 09/18/20, 09:44

  11. Oliver Klee voted on patch set 3 CR +1 09/18/20, 09:49

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 09/18/20, 10:52

  13. Sascha Egerer voted on patch set 3 V +1 CR +1 09/18/20, 10:53

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 09/18/20, 21:04

  15. Christian Kuhn merged patch set 4 09/18/20, 21:04