Review main Merged

65661[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Authentication

Sascha Egerer CR +2 V +2 Easy +12 −8 updated 09/23/20, 14:27

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1316

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:15

  2. Sascha Egerer wrote 09/09/20, 17:25

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:25

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 17:52 Completed build in 37m 01s on Wed, 9 Sep, 05:52 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5426

  5. Oliver Klee voted on patch set 2 CR +1 09/09/20, 18:30

  6. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:50

  7. TYPO3com voted on patch set 3 V +1 09/10/20, 18:23 Completed build in 1h 10m 46s on Thu, 10 Sep, 06:23 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5507

  8. Oliver Klee voted on patch set 3 CR +1 09/10/20, 19:12

  9. Daniel Goerz uploaded patch set 4 09/21/20, 13:38

  10. Daniel Goerz voted on patch set 4 V +1 CR +1 09/21/20, 13:40

  11. TYPO3com voted on patch set 4 V +1 09/21/20, 13:50 Completed build in 11m 16s on Mon, 21 Sep, 01:50 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5792

  12. Oliver Klee voted on patch set 4 CR +1 09/21/20, 14:14

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 09/23/20, 13:50

  14. Benni Mack voted on patch set 4 V +1 CR +1 09/23/20, 14:26

  15. Benni Mack voted on patch set 4 V +2 CR +2 09/23/20, 14:27

  16. Benni Mack merged patch set 5 09/23/20, 14:27