Review main Merged

65662[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Html

Sascha Egerer CR +2 V +2 Easy +12 −6 updated 09/11/20, 08:06

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1420

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:15

  2. Sascha Egerer wrote 09/09/20, 17:25

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:25

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 17:56 Completed build in 34m 13s on Wed, 9 Sep, 05:56 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5427

  5. Oliver Klee voted on patch set 2 CR +1 09/09/20, 18:31

  6. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:50

  7. Jörg Bösche voted on patch set 3 CR +1 09/10/20, 08:50

  8. TYPO3com voted on patch set 3 V +1 09/10/20, 18:20 Completed build in 1h 07m 21s on Thu, 10 Sep, 06:20 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5506

  9. Sascha Egerer commented on patch set 3 CR -1 09/10/20, 18:31

    HtmlParser.php:60 Unresolved

    If preg_split does not return an array with items we can do an early return. I would go for this instead if (empty($parts)) { return []; }

    RteHtmlParser.php:239 Unresolved

    If `preg_replace` does return a string or NULL if an error occured. So i would choose this instead $value = preg_replace('/<p>&nbsp;<\/p>$/', '<p>&nbsp;</p><p>&nbsp;</p>', $value) ?? $value;

    RteHtmlParser.php:714 Unresolved

    same as above

    RteHtmlParser.php:716 Unresolved

    same as above
  10. Sascha Egerer uploaded patch set 4 09/10/20, 18:37

  11. Sascha Egerer uploaded patch set 5 09/10/20, 18:43

  12. Sascha Egerer uploaded patch set 6 09/10/20, 18:47

  13. TYPO3com voted on patch set 4 V -1 09/10/20, 18:50 Completed build in 12m 31s on Thu, 10 Sep, 06:50 PM Test Summary: 71369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5510

  14. TYPO3com commented on patch set 5 09/10/20, 19:00 Completed build in 17m 12s on Thu, 10 Sep, 07:00 PM Test Summary: 72327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5511

  15. TYPO3com voted on patch set 6 V -1 09/10/20, 19:01 Completed build in 14m 03s on Thu, 10 Sep, 07:01 PM Test Summary: 1 of 73313 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5512

  16. Daniel Goerz voted on patch set 6 V +1 CR +1 09/11/20, 07:07

  17. TYPO3com voted on patch set 6 V +1 09/11/20, 07:08 Completed build in 12h 34m 52s on Fri, 11 Sep, 07:08 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5512

  18. Oli Bartsch voted on patch set 6 V +1 CR +1 09/11/20, 07:17

  19. Daniel Goerz voted on patch set 6 V +2 CR +2 09/11/20, 08:06

  20. Daniel Goerz merged patch set 7 09/11/20, 08:06