Review main Merged

65663[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Cache

Sascha Egerer CR +2 V +2 Easy +20 −15 updated 09/25/20, 10:09

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 2226

Show 1 earlier messages
  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:15

  1. Sascha Egerer wrote 09/09/20, 17:25

    Topic set to phpstan
  2. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:25

  3. TYPO3com voted on patch set 1 V +1 09/09/20, 18:00 Completed build in 38m 20s on Wed, 9 Sep, 06:00 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5428

  4. Oliver Klee voted on patch set 2 CR +1 09/09/20, 18:34

  5. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:49

  6. TYPO3com voted on patch set 3 V +1 09/10/20, 09:48 Completed build in 48m 57s on Thu, 10 Sep, 09:48 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5477

  7. Jörg Bösche voted on patch set 3 CR +1 09/10/20, 13:29

  8. Oliver Klee voted on patch set 3 CR +1 09/10/20, 14:51

  9. Daniel Goerz uploaded patch set 4 09/23/20, 17:12

  10. Oliver Klee voted on patch set 4 CR +1 09/23/20, 17:32

  11. TYPO3com voted on patch set 4 V +1 09/23/20, 17:48 Completed build in 28m 24s on Wed, 23 Sep, 05:48 PM Test Summary: 73699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5897

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 09/23/20, 18:09

  13. Christian Kuhn voted on patch set 4 V 0 CR 0 09/23/20, 18:15

  14. Christian Kuhn commented on patch set 4 09/23/20, 18:19

    PdoBackend.php:287

    This should throw a global \RuntimeException() - if that file does not exist or can't be read, something is seriously broken with the instance...
  15. Oli Bartsch commented on patch set 4 09/23/20, 18:20

    FileBackend.php:142

    [EA] This type casting is not necessary, as the argument is of needed type. $lifetime can be null but than it falls back to $this->defaultLifetime which can't be null. It's furthermore the only backend using this cast.

    FileBackend.php:143

    $expiryTime is only used in the next line and casted to string. Therefore the int cast seems to be superfluous
  16. Daniel Goerz commented on patch set 4 CR -1 09/23/20, 18:37

    will take care
  17. Alexander Schnitzler commented on patch set 4 09/25/20, 06:56

    FileBackend.php:143 Reply

    I have a different opinion here. Even if that value is only used as a string, it's actual value should remain an integer. > $expiryTime is only used in the next line and casted to string. The statement is not correct, since the variable remains an integer but its value is cast to string and passed into str_pad. It's similar but still different.
  18. Daniel Goerz uploaded patch set 5 09/25/20, 08:10

  19. Daniel Goerz commented on patch set 5 V +1 CR +1 09/25/20, 08:11

    FileBackend.php:142 Reply

    Ack

    FileBackend.php:143 Reply

    Ack

    PdoBackend.php:287 Reply

    Done
  20. TYPO3com voted on patch set 5 V +1 09/25/20, 08:22 Completed build in 12m 04s on Fri, 25 Sep, 08:22 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5927

  21. Oli Bartsch commented on patch set 5 V +1 CR +1 09/25/20, 08:33

    FileBackend.php:143 Reply

    Ack
  22. Oliver Klee voted on patch set 5 CR +1 09/25/20, 09:13

  23. Alexander Schnitzler voted on patch set 5 V +1 CR +1 09/25/20, 10:08

  24. Daniel Goerz voted on patch set 5 V +2 CR +2 09/25/20, 10:09

  25. Daniel Goerz merged patch set 6 09/25/20, 10:09