Review main Merged

65665[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Mail

Sascha Egerer CR +2 V +2 Easy +15 −15 updated 10/06/20, 11:45

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1214

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:15

  2. Sascha Egerer wrote 09/09/20, 17:25

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:25

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 18:05 Completed build in 26m 24s on Wed, 9 Sep, 06:05 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5430

  5. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:58

  6. TYPO3com voted on patch set 3 V +1 09/10/20, 17:22 Completed build in 17m 46s on Thu, 10 Sep, 05:22 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5494

  7. Oliver Klee voted on patch set 3 CR +1 09/10/20, 19:16

  8. Jörg Bösche voted on patch set 3 CR +1 09/11/20, 06:10

  9. Daniel Goerz voted on patch set 3 V +1 CR +1 09/18/20, 08:26

  10. Tymoteusz Motylewski commented on patch set 3 09/21/20, 21:35

    FileSpool.php:155

    Shouldnt we rather handle a case where null is returned?
  11. Daniel Goerz commented on patch set 3 10/06/20, 11:42

    FileSpool.php:155 Reply Unresolved

    Dont really know what could go wrong here that needs a specific error case handling. Would leave it as is to make phpstan happy and move on.
  12. Alexander Schnitzler voted on patch set 3 V +1 CR +1 10/06/20, 11:42

  13. Daniel Goerz voted on patch set 3 V +2 CR +2 10/06/20, 11:45

  14. Daniel Goerz merged patch set 4 10/06/20, 11:45