65665[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Mail
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Klee +1
- Alexander Schnitzler +1
- Jörg Bösche +1
-
Verified V +2 Done
- Daniel Goerz +2
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1214
-
Sascha Egerer uploaded patch set 1 09/09/20, 17:15
-
Sascha Egerer wrote 09/09/20, 17:25
Topic set to phpstan -
Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:25
-
TYPO3com voted on patch set 1 V +1 09/09/20, 18:05 Completed build in 26m 24s on Wed, 9 Sep, 06:05 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5430
-
Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:58
-
TYPO3com voted on patch set 3 V +1 09/10/20, 17:22 Completed build in 17m 46s on Thu, 10 Sep, 05:22 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5494
-
Oliver Klee voted on patch set 3 CR +1 09/10/20, 19:16
-
Jörg Bösche voted on patch set 3 CR +1 09/11/20, 06:10
-
Daniel Goerz voted on patch set 3 V +1 CR +1 09/18/20, 08:26
-
Tymoteusz Motylewski commented on patch set 3 09/21/20, 21:35
FileSpool.php:155Shouldnt we rather handle a case where null is returned? -
Daniel Goerz commented on patch set 3 10/06/20, 11:42
FileSpool.php:155Reply UnresolvedDont really know what could go wrong here that needs a specific error case handling. Would leave it as is to make phpstan happy and move on. -
Alexander Schnitzler voted on patch set 3 V +1 CR +1 10/06/20, 11:42
-
Daniel Goerz voted on patch set 3 V +2 CR +2 10/06/20, 11:45
-
Daniel Goerz merged patch set 4 10/06/20, 11:45