Review main Merged

65666[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Imaging

Sascha Egerer CR +2 V +2 Normal +47 −40 updated 10/06/20, 12:51

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1215

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:15

  2. Sascha Egerer wrote 09/09/20, 17:25

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:25

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 18:12 Completed build in 33m 54s on Wed, 9 Sep, 06:12 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5431

  5. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:55

  6. TYPO3com voted on patch set 3 V +1 09/10/20, 17:55 Completed build in 42m 47s on Thu, 10 Sep, 05:55 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5499

  7. Oliver Klee voted on patch set 3 CR +1 09/10/20, 19:13

  8. Jörg Bösche voted on patch set 3 CR +1 09/11/20, 13:03

  9. Daniel Goerz uploaded patch set 4 10/06/20, 12:17

  10. Daniel Goerz voted on patch set 4 V +1 CR +1 10/06/20, 12:19

  11. Oliver Klee voted on patch set 4 CR +1 10/06/20, 12:28

  12. TYPO3com voted on patch set 4 V +1 10/06/20, 12:35 Completed build in 17m 06s on Tue, 6 Oct, 12:35 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6271

  13. Alexander Schnitzler voted on patch set 4 V +1 CR +1 10/06/20, 12:50

  14. Daniel Goerz voted on patch set 4 V +2 CR +2 10/06/20, 12:51

  15. Daniel Goerz merged patch set 5 10/06/20, 12:51