Review main Merged

65667[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Site

Sascha Egerer CR +2 V +2 Easy +1 −1 updated 09/18/20, 20:31

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:16

  2. Sascha Egerer wrote 09/09/20, 17:25

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:25

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 18:17 Completed build in 34m 19s on Wed, 9 Sep, 06:17 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5432

  5. Oliver Klee voted on patch set 2 CR +1 09/09/20, 18:27

  6. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:52

  7. TYPO3com voted on patch set 3 V +1 09/10/20, 17:59 Completed build in 46m 20s on Thu, 10 Sep, 05:59 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5503

  8. Oliver Klee voted on patch set 3 CR +1 09/10/20, 19:12

  9. Daniel Goerz voted on patch set 3 V +1 CR +1 09/18/20, 08:55

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 09/18/20, 20:31

  11. Christian Kuhn merged patch set 4 09/18/20, 20:31