Review main Merged

65668[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core ExpressionLanguage

Sascha Egerer CR +2 V +2 Easy +2 −2 updated 09/21/20, 12:13

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Sascha Egerer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Sascha Egerer +1

Issues 1

Files 1

Review log 1213

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:16

  2. Sascha Egerer wrote 09/09/20, 17:26

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:26

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 18:21 Completed build in 38m 12s on Wed, 9 Sep, 06:21 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5433

  5. Oliver Klee voted on patch set 2 CR +1 09/09/20, 18:25

  6. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:53

  7. Sascha Egerer commented on patch set 3 CR -1 09/21/20, 05:21

    ProviderInterface.php:30

    What is the background of this change? Looks like it's an array of ExpressionFunctionProviderInterface. Why do we remove this info?
  8. Alexander Schnitzler commented on patch set 3 09/21/20, 10:02

    ProviderInterface.php:30 Reply Unresolved

    > Looks like it's an array of ExpressionFunctionProviderInterface. No, the array doesn't hold instances (objects), it holds strings that are class names.
  9. Oliver Klee voted on patch set 3 CR +1 09/21/20, 10:34

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 09/21/20, 10:47

  11. Sascha Egerer voted on patch set 3 V +1 CR +1 09/21/20, 11:21

  12. Daniel Goerz voted on patch set 3 V +2 CR +2 09/21/20, 12:13

  13. Daniel Goerz merged patch set 4 09/21/20, 12:13