Review main Merged

65669[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Http

Sascha Egerer CR +2 V +2 Easy +6 −6 updated 09/23/20, 14:13

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1416

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:16

  2. Sascha Egerer wrote 09/09/20, 17:26

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:26

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 18:25 Completed build in 42m 28s on Wed, 9 Sep, 06:25 PM Test Summary: 73171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5434

  5. Oliver Klee voted on patch set 2 CR +1 09/09/20, 18:28

  6. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:51

  7. TYPO3com voted on patch set 3 V +1 09/10/20, 18:02 Completed build in 50m 01s on Thu, 10 Sep, 06:02 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5505

  8. Oliver Klee voted on patch set 3 CR +1 09/10/20, 19:12

  9. Benni Mack voted on patch set 3 CR +2 09/12/20, 18:46

  10. Daniel Goerz voted on patch set 3 V +1 CR +1 09/23/20, 09:50

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 09/23/20, 13:59

  12. Benni Mack voted on patch set 3 V +2 09/23/20, 14:09

  13. Benni Mack voted on patch set 3 V +1 CR +1 09/23/20, 14:10

  14. Benni Mack voted on patch set 3 V +2 CR +2 09/23/20, 14:10

  15. Daniel Goerz voted on patch set 3 V +2 CR +2 09/23/20, 14:13

  16. Daniel Goerz merged patch set 4 09/23/20, 14:13