Review main Merged

65670[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core LinkHandling

Sascha Egerer CR +2 V +2 Easy +1 −1 updated 09/23/20, 14:19

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:16

  2. Sascha Egerer wrote 09/09/20, 17:26

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:26

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 18:29 Completed build in 46m 41s on Wed, 9 Sep, 06:29 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5435

  5. Sascha Egerer commented on patch set 2 09/10/20, 08:14

    LegacyLinkNotationConverter.php:74 Unresolved

    Not sure if this would be cleaner as we have to call parse_url twice (or do an assignment in the condition which is IMO also bad code smell) } elseif (parse_url($linkParameter, PHP_URL_PATH) !== false && GeneralUtility::validEmail(parse_url($linkParameter, PHP_URL_PATH))) { Opinions?
  6. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:44

  7. TYPO3com voted on patch set 3 V +1 09/10/20, 09:13 Completed build in 28m 59s on Thu, 10 Sep, 09:13 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5468

  8. Benni Mack voted on patch set 3 V +1 CR +1 09/23/20, 14:10

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 09/23/20, 14:11

  10. Daniel Goerz voted on patch set 3 V +2 CR +2 09/23/20, 14:19

  11. Daniel Goerz merged patch set 4 09/23/20, 14:19