65670[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core LinkHandling
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 911
-
Sascha Egerer uploaded patch set 1 09/09/20, 17:16
-
Sascha Egerer wrote 09/09/20, 17:26
Topic set to phpstan -
Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:26
-
TYPO3com voted on patch set 1 V +1 09/09/20, 18:29 Completed build in 46m 41s on Wed, 9 Sep, 06:29 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5435
-
Sascha Egerer commented on patch set 2 09/10/20, 08:14
LegacyLinkNotationConverter.php:74UnresolvedNot sure if this would be cleaner as we have to call parse_url twice (or do an assignment in the condition which is IMO also bad code smell) } elseif (parse_url($linkParameter, PHP_URL_PATH) !== false && GeneralUtility::validEmail(parse_url($linkParameter, PHP_URL_PATH))) { Opinions? -
Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:44
-
TYPO3com voted on patch set 3 V +1 09/10/20, 09:13 Completed build in 28m 59s on Thu, 10 Sep, 09:13 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5468
-
Benni Mack voted on patch set 3 V +1 CR +1 09/23/20, 14:10
-
Oli Bartsch voted on patch set 3 V +1 CR +1 09/23/20, 14:11
-
Daniel Goerz voted on patch set 3 V +2 CR +2 09/23/20, 14:19
-
Daniel Goerz merged patch set 4 09/23/20, 14:19