65671[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Type
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Sascha Egerer +1
-
Verified V +2 Done
- Daniel Goerz +2
- Sascha Egerer +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1316
-
Sascha Egerer uploaded patch set 1 09/09/20, 17:16
-
Sascha Egerer wrote 09/09/20, 17:26
Topic set to phpstan -
Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:26
-
Oliver Klee voted on patch set 2 CR +1 09/09/20, 18:35
-
TYPO3com voted on patch set 1 V +1 09/09/20, 18:37 Completed build in 55m 00s on Wed, 9 Sep, 06:37 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5436
-
Sascha Egerer voted on patch set 2 V +1 CR +1 09/10/20, 06:58
-
Daniel Goerz commented on patch set 2 CR -1 09/10/20, 08:34
patch needs its own forge issue -
Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:42
-
TYPO3com voted on patch set 3 V +1 09/10/20, 09:04 Completed build in 20m 21s on Thu, 10 Sep, 09:04 AM Test Summary: 73171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5466
-
Jörg Bösche voted on patch set 3 V +1 CR +1 09/11/20, 06:39
-
Oli Bartsch commented on patch set 3 09/11/20, 07:22
ImageInfo.php:122UnresolvedWould suggest to not call `simplexml_load_string` if file_get_contests returned FALSE. $fileContent = file_get_contents($this->getPathname()); if($fileContent === false) { return false; } -
Daniel Goerz uploaded patch set 4 09/11/20, 07:37
-
Sascha Egerer voted on patch set 4 V +1 CR +1 09/11/20, 07:40
-
TYPO3com voted on patch set 4 V +1 09/11/20, 07:51 Completed build in 13m 31s on Fri, 11 Sep, 07:51 AM Test Summary: 73215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5530
-
Daniel Goerz voted on patch set 4 V +2 CR +2 09/11/20, 07:58
-
Daniel Goerz merged patch set 5 09/11/20, 07:58