Review main Merged

65673[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Resource

Sascha Egerer CR +2 V +2 Normal +55 −45 updated 11/23/20, 16:11

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 1519

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:16

  2. Sascha Egerer wrote 09/09/20, 17:26

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:26

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 18:42 Completed build in 59m 05s on Wed, 9 Sep, 06:42 PM Test Summary: 73171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5438

  5. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:48

  6. TYPO3com voted on patch set 3 V +1 09/10/20, 09:53 Completed build in 53m 28s on Thu, 10 Sep, 09:53 AM Test Summary: 73171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5476

  7. Oliver Klee voted on patch set 3 CR +1 09/10/20, 12:29

  8. Jörg Bösche voted on patch set 3 CR +1 09/10/20, 13:15

  9. Daniel Goerz uploaded patch set 4 10/06/20, 13:34

  10. TYPO3com voted on patch set 4 V +1 10/06/20, 13:50 Completed build in 16m 21s on Tue, 6 Oct, 01:50 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6278

  11. Oliver Klee voted on patch set 4 CR +1 10/06/20, 13:52

  12. Alexander Schnitzler uploaded patch set 5 10/06/20, 14:02

  13. Daniel Goerz voted on patch set 5 V +1 CR +1 10/06/20, 14:13

  14. TYPO3com voted on patch set 5 V +1 10/06/20, 14:25 Completed build in 20m 22s on Tue, 6 Oct, 02:25 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6281

  15. Alexander Schnitzler voted on patch set 5 V +1 CR +1 10/06/20, 14:31

  16. Daniel Goerz voted on patch set 5 V +2 CR +2 10/06/20, 14:40

  17. Daniel Goerz merged patch set 6 10/06/20, 14:40

  18. Alexander Schnitzler commented on patch set 6 11/23/20, 15:49

    ResourceFactory.php:242

    $parts[0] can be 'EXT' here. This is a regression which needs to be fixed.
  19. Daniel Goerz commented on patch set 6 11/23/20, 16:11