Review main Merged

65674[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Configuration

Sascha Egerer CR +2 V +2 Easy +4 −4 updated 09/10/20, 09:40

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Sascha Egerer +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Sascha Egerer +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1315

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:16

  2. Sascha Egerer wrote 09/09/20, 17:26

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:26

  4. TYPO3com voted on patch set 1 V +1 09/09/20, 18:46 Completed build in 1h 03m 43s on Wed, 9 Sep, 06:46 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5439

  5. Sascha Egerer voted on patch set 2 V +1 CR +1 09/10/20, 06:56

  6. Jörg Bösche voted on patch set 2 V +1 CR +1 09/10/20, 07:36

  7. Daniel Goerz commented on patch set 2 CR -1 09/10/20, 08:34

    patch needs its own forge issue
  8. Daniel Goerz commented on patch set 2 09/10/20, 08:34

    patch needs its own forge issue
  9. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:41

  10. Jörg Bösche voted on patch set 3 V +1 CR +1 09/10/20, 08:47

  11. Oliver Klee voted on patch set 3 CR +1 09/10/20, 08:51

  12. TYPO3com voted on patch set 3 V +1 09/10/20, 09:00 Completed build in 15m 57s on Thu, 10 Sep, 09:00 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5465

  13. Daniel Goerz voted on patch set 3 V +2 CR +2 09/10/20, 09:28

  14. Sascha Egerer voted on patch set 3 V +1 CR +1 09/10/20, 09:33

  15. Daniel Goerz merged patch set 4 09/10/20, 09:40