65675[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Service
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1619
-
Sascha Egerer uploaded patch set 1 09/09/20, 17:16
-
Sascha Egerer wrote 09/09/20, 17:26
Topic set to phpstan -
Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:26
-
Sascha Egerer commented on patch set 2 CR -1 09/10/20, 07:48
AbstractService.php:356UnresolvedI would not cast this value to string but adjust the condition below.AbstractService.php:358Unresolved`$absFile` should be `$absFile !== false` instead which means it is a stringZipService.php:76Unresolvedshould not be casted but condition below should be adjustedZipService.php:77Unresolvedadd `$entryName !== false && before doing the preg_match`OpcodeCacheService.php:77Unresolvedadd early return instead of casting. if (empty(ini_get('disable_functions'))) { return true; } -
Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:46
-
TYPO3com voted on patch set 3 V +1 09/10/20, 09:27 Completed build in 28m 17s on Thu, 10 Sep, 09:27 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5471
-
Markus Klösges commented on patch set 3 CR -1 09/25/20, 13:31
AbstractService.php:338UnresolvedThis doesn't look right. There is an explicit check for the === false case below. Like this we are suppressing the error message. -
Andreas Kienast uploaded patch set 4 09/26/20, 08:44
-
Andreas Kienast voted on patch set 4 V +1 CR +1 09/26/20, 08:45
-
TYPO3com voted on patch set 4 V +1 09/26/20, 08:57 Completed build in 11m 58s on Sat, 26 Sep, 08:57 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5977
-
Oli Bartsch voted on patch set 4 V +1 CR +1 09/26/20, 09:27
-
Oliver Klee voted on patch set 4 CR +1 09/26/20, 10:29
-
Daniel Goerz commented on patch set 4 CR -1 09/26/20, 10:36
AbstractService.php:343UnresolvedThis is a potentially breaking change -
Daniel Goerz uploaded patch set 5 09/26/20, 11:21
-
TYPO3com voted on patch set 5 V +1 09/26/20, 11:33 Completed build in 12m 25s on Sat, 26 Sep, 11:33 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5983
-
Daniel Goerz voted on patch set 5 V +1 CR +1 09/26/20, 11:54
-
Oliver Klee voted on patch set 5 CR +1 09/26/20, 12:27
-
Benni Mack voted on patch set 5 V +2 CR +2 09/28/20, 08:03
-
Benni Mack merged patch set 6 09/28/20, 08:03