Review main Merged

65675[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Service

Sascha Egerer CR +2 V +2 Easy +11 −7 updated 09/28/20, 08:03

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1619

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:16

  2. Sascha Egerer wrote 09/09/20, 17:26

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:26

  4. Sascha Egerer commented on patch set 2 CR -1 09/10/20, 07:48

    AbstractService.php:356 Unresolved

    I would not cast this value to string but adjust the condition below.

    AbstractService.php:358 Unresolved

    `$absFile` should be `$absFile !== false` instead which means it is a string

    ZipService.php:76 Unresolved

    should not be casted but condition below should be adjusted

    ZipService.php:77 Unresolved

    add `$entryName !== false && before doing the preg_match`

    OpcodeCacheService.php:77 Unresolved

    add early return instead of casting. if (empty(ini_get('disable_functions'))) { return true; }
  5. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:46

  6. TYPO3com voted on patch set 3 V +1 09/10/20, 09:27 Completed build in 28m 17s on Thu, 10 Sep, 09:27 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5471

  7. Markus Klösges commented on patch set 3 CR -1 09/25/20, 13:31

    AbstractService.php:338 Unresolved

    This doesn't look right. There is an explicit check for the === false case below. Like this we are suppressing the error message.
  8. Andreas Kienast uploaded patch set 4 09/26/20, 08:44

  9. Andreas Kienast voted on patch set 4 V +1 CR +1 09/26/20, 08:45

  10. TYPO3com voted on patch set 4 V +1 09/26/20, 08:57 Completed build in 11m 58s on Sat, 26 Sep, 08:57 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5977

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 09/26/20, 09:27

  12. Oliver Klee voted on patch set 4 CR +1 09/26/20, 10:29

  13. Daniel Goerz commented on patch set 4 CR -1 09/26/20, 10:36

    AbstractService.php:343 Unresolved

    This is a potentially breaking change
  14. Daniel Goerz uploaded patch set 5 09/26/20, 11:21

  15. TYPO3com voted on patch set 5 V +1 09/26/20, 11:33 Completed build in 12m 25s on Sat, 26 Sep, 11:33 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5983

  16. Daniel Goerz voted on patch set 5 V +1 CR +1 09/26/20, 11:54

  17. Oliver Klee voted on patch set 5 CR +1 09/26/20, 12:27

  18. Benni Mack voted on patch set 5 V +2 CR +2 09/28/20, 08:03

  19. Benni Mack merged patch set 6 09/28/20, 08:03