Review main Merged

65676[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Routing

Sascha Egerer CR +2 V +2 Easy +10 −9 updated 09/23/20, 17:06

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1416

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:16

  2. Sascha Egerer wrote 09/09/20, 17:26

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:26

  4. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:55

  5. TYPO3com voted on patch set 3 V +1 09/10/20, 17:33 Completed build in 21m 08s on Thu, 10 Sep, 05:33 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5498

  6. Oliver Klee voted on patch set 3 CR +1 09/10/20, 19:16

  7. Jörg Bösche voted on patch set 3 CR +1 09/11/20, 12:43

  8. Benni Mack voted on patch set 3 V +1 CR +1 09/23/20, 14:12

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 09/23/20, 15:20

  10. Daniel Goerz uploaded patch set 4 09/23/20, 16:20

  11. Daniel Goerz voted on patch set 4 V +1 CR +1 09/23/20, 16:20

  12. Benni Mack voted on patch set 4 V +1 CR +1 09/23/20, 16:34

  13. TYPO3com voted on patch set 4 V +1 09/23/20, 16:47 Completed build in 25m 01s on Wed, 23 Sep, 04:47 PM Test Summary: 73697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5886

  14. Oli Bartsch voted on patch set 4 V +1 CR +1 09/23/20, 17:05

  15. Daniel Goerz voted on patch set 4 V +2 CR +2 09/23/20, 17:06

  16. Daniel Goerz merged patch set 5 09/23/20, 17:06