Review main Merged

65677[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core TimeTracker

Sascha Egerer CR +2 V +2 Easy +1 −1 updated 09/11/20, 07:20

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Sascha Egerer +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Sascha Egerer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:16

  2. Sascha Egerer wrote 09/09/20, 17:27

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:27

  4. Sascha Egerer voted on patch set 2 V +1 CR +1 09/10/20, 07:49

  5. Daniel Goerz commented on patch set 2 CR -1 09/10/20, 08:34

    patch needs its own forge issue
  6. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:40

  7. TYPO3com voted on patch set 3 V +1 09/10/20, 08:53 Completed build in 12m 47s on Thu, 10 Sep, 08:53 AM Test Summary: 73172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5464

  8. Sascha Egerer voted on patch set 3 V +1 CR +1 09/10/20, 19:52

  9. Jörg Bösche voted on patch set 3 CR +1 09/11/20, 06:32

  10. Daniel Goerz voted on patch set 3 V +2 CR +2 09/11/20, 07:20

  11. Daniel Goerz merged patch set 4 09/11/20, 07:20