Review main Merged

65678[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Session

Sascha Egerer CR +2 V +2 Easy +1 −1 updated 09/18/20, 20:23

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:16

  2. Sascha Egerer wrote 09/09/20, 17:27

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:27

  4. Sascha Egerer commented on patch set 2 CR -1 09/10/20, 07:52

    SessionManager.php:98 Unresolved

    are we sure that the key is always a string? Can also be an integer, right?
  5. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:45

  6. TYPO3com voted on patch set 3 V +1 09/10/20, 09:24 Completed build in 24m 38s on Thu, 10 Sep, 09:24 AM Test Summary: 73171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5470

  7. Daniel Goerz voted on patch set 3 V +1 CR +1 09/18/20, 09:15

  8. Oliver Klee voted on patch set 3 CR +1 09/18/20, 09:49

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 09/18/20, 20:23

  10. Christian Kuhn merged patch set 4 09/18/20, 20:23