65678[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Session
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Daniel Goerz +1
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 910
-
Sascha Egerer uploaded patch set 1 09/09/20, 17:16
-
Sascha Egerer wrote 09/09/20, 17:27
Topic set to phpstan -
Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:27
-
Sascha Egerer commented on patch set 2 CR -1 09/10/20, 07:52
SessionManager.php:98Unresolvedare we sure that the key is always a string? Can also be an integer, right? -
Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:45
-
TYPO3com voted on patch set 3 V +1 09/10/20, 09:24 Completed build in 24m 38s on Thu, 10 Sep, 09:24 AM Test Summary: 73171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5470
-
Daniel Goerz voted on patch set 3 V +1 CR +1 09/18/20, 09:15
-
Oliver Klee voted on patch set 3 CR +1 09/18/20, 09:49
-
Christian Kuhn voted on patch set 3 V +2 CR +2 09/18/20, 20:23
-
Christian Kuhn merged patch set 4 09/18/20, 20:23