Review main Merged

65679[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Utility

Sascha Egerer CR +2 V +2 Normal +59 −45 updated 10/06/20, 13:38

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1113

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:16

  2. Sascha Egerer wrote 09/09/20, 17:27

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:27

  4. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:56

  5. Jörg Bösche voted on patch set 3 CR +1 09/10/20, 09:05

  6. TYPO3com voted on patch set 3 V +1 09/10/20, 17:17 Completed build in 12m 34s on Thu, 10 Sep, 05:17 PM Test Summary: 73171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5493

  7. Oliver Klee voted on patch set 3 CR +1 09/10/20, 19:17

  8. Daniel Goerz uploaded patch set 4 10/06/20, 12:48

  9. Daniel Goerz voted on patch set 4 V +1 CR +1 10/06/20, 12:48

  10. Alexander Schnitzler voted on patch set 4 V +1 CR +1 10/06/20, 12:52

  11. TYPO3com voted on patch set 4 V +1 10/06/20, 13:09 Completed build in 21m 18s on Tue, 6 Oct, 01:09 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6274

  12. Daniel Goerz voted on patch set 4 V +2 CR +2 10/06/20, 13:38

  13. Daniel Goerz merged patch set 5 10/06/20, 13:38