Review main Merged

65681[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Package

Sascha Egerer CR +2 V +2 Easy +11 −3 updated 09/21/20, 06:59

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Sascha Egerer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Sascha Egerer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1416

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:16

  2. Sascha Egerer wrote 09/09/20, 17:27

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:27

  4. Sascha Egerer commented on patch set 2 CR -1 09/10/20, 07:55

    PackageManager.php:819 Unresolved

    instead of casting we should check the return value and maybe throw exception as below.

    PackageManager.php:912 Unresolved

    return value should be handled more gracefully

    PackageManager.php:917 Unresolved

    return value should be handled more gracefully
  5. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:44

  6. TYPO3com voted on patch set 3 V +1 09/10/20, 09:18 Completed build in 24m 03s on Thu, 10 Sep, 09:18 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5469

  7. Jörg Bösche voted on patch set 3 CR +1 09/10/20, 13:37

  8. Oliver Klee voted on patch set 3 CR +1 09/10/20, 14:50

  9. Benni Mack voted on patch set 3 CR +2 09/12/20, 18:46

  10. Guido Schmechel voted on patch set 3 CR +1 09/13/20, 09:00

  11. Sascha Egerer uploaded patch set 4 09/21/20, 04:56

  12. Sascha Egerer commented on patch set 4 09/21/20, 04:58

    IMO it's better code if we check for unexpected values here and handle them instead of just casting them to a string. Any opinions on that? Feel free to go back to the last patch set if most of the people are against that.
  13. Sascha Egerer voted on patch set 4 V +1 CR +1 09/21/20, 04:59

  14. TYPO3com voted on patch set 4 V +1 09/21/20, 05:09 Completed build in 12m 49s on Mon, 21 Sep, 05:09 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5776

  15. Daniel Goerz voted on patch set 4 V +2 CR +2 09/21/20, 06:59

  16. Daniel Goerz merged patch set 5 09/21/20, 06:59