65681[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Package
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Sascha Egerer +1
-
Verified V +2 Done
- Daniel Goerz +2
- Sascha Egerer +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1416
-
Sascha Egerer uploaded patch set 1 09/09/20, 17:16
-
Sascha Egerer wrote 09/09/20, 17:27
Topic set to phpstan -
Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:27
-
Sascha Egerer commented on patch set 2 CR -1 09/10/20, 07:55
PackageManager.php:819Unresolvedinstead of casting we should check the return value and maybe throw exception as below.PackageManager.php:912Unresolvedreturn value should be handled more gracefullyPackageManager.php:917Unresolvedreturn value should be handled more gracefully -
Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:44
-
TYPO3com voted on patch set 3 V +1 09/10/20, 09:18 Completed build in 24m 03s on Thu, 10 Sep, 09:18 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5469
-
Jörg Bösche voted on patch set 3 CR +1 09/10/20, 13:37
-
Oliver Klee voted on patch set 3 CR +1 09/10/20, 14:50
-
Benni Mack voted on patch set 3 CR +2 09/12/20, 18:46
-
Guido Schmechel voted on patch set 3 CR +1 09/13/20, 09:00
-
Sascha Egerer uploaded patch set 4 09/21/20, 04:56
-
Sascha Egerer commented on patch set 4 09/21/20, 04:58
IMO it's better code if we check for unexpected values here and handle them instead of just casting them to a string. Any opinions on that? Feel free to go back to the last patch set if most of the people are against that. -
Sascha Egerer voted on patch set 4 V +1 CR +1 09/21/20, 04:59
-
TYPO3com voted on patch set 4 V +1 09/21/20, 05:09 Completed build in 12m 49s on Mon, 21 Sep, 05:09 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5776
-
Daniel Goerz voted on patch set 4 V +2 CR +2 09/21/20, 06:59
-
Daniel Goerz merged patch set 5 09/21/20, 06:59