Review main Merged

65682[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Charset

Sascha Egerer CR +2 V +2 Easy +9 −9 updated 09/23/20, 13:49

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:17

  2. Sascha Egerer wrote 09/09/20, 17:21

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:21

  4. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:54

  5. TYPO3com voted on patch set 3 V +1 09/10/20, 17:36 Completed build in 23m 38s on Thu, 10 Sep, 05:36 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5500

  6. Oliver Klee voted on patch set 3 CR +1 09/10/20, 19:15

  7. Jörg Bösche voted on patch set 3 CR +1 09/11/20, 06:33

  8. Daniel Goerz voted on patch set 3 V +1 CR +1 09/18/20, 08:21

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 09/23/20, 13:45

  10. Daniel Goerz voted on patch set 3 V +2 CR +2 09/23/20, 13:49

  11. Daniel Goerz merged patch set 4 09/23/20, 13:49